prjemian
commented
3 years ago TODO and FIXME code annotations:
bash-4.2$ git grep TODO:
profile_bluesky/startup/instrument/callbacks/nxwriter_usaxs.py: # TODO: identify what additional data is needed to collect
profile_bluesky/startup/instrument/collection.py:from .devices.blackfly import AD_prime_plugin # TODO: temporary
profile_bluesky/startup/instrument/devices/ad_tiff_upstream.py: # TODO: taking a guess here, it's needed if databroker is to *read* t
profile_bluesky/startup/instrument/devices/amplifiers.py: # TODO: change these asserts into if, not good coding practice.
profile_bluesky/startup/instrument/devices/area_detector_common.py:# TODO: from apstools.devices import AD_EpicsTiffFileName
profile_bluesky/startup/instrument/devices/area_detector_common.py: # TODO: for apstools
profile_bluesky/startup/instrument/devices/area_detector_common.py: if not write_path.endswith("/"): # TODO: need to add into apst
profile_bluesky/startup/instrument/devices/axis_tuning.py: # TODO: first, re-position piezo considering hysteresis?
profile_bluesky/startup/instrument/devices/axis_tuning.py: # TODO: first, re-position piezo considering hysteresis?
profile_bluesky/startup/instrument/devices/blackfly.py:# TODO: from apstools.devices import AD_prime_plugin
profile_bluesky/startup/instrument/devices/general_terms.py: # TODO: and then reset terms as approriate
profile_bluesky/startup/instrument/devices/general_terms.py: # TODO: next test if not in SAXS or WAXS mode
profile_bluesky/startup/instrument/devices/general_terms.py: # TODO: these are particular to the amplifier
profile_bluesky/startup/instrument/devices/general_terms.py: return upd_controls.auto.lurange.get() # TODO: check return value is in
profile_bluesky/startup/instrument/devices/permit.py:# TODO: needs some thought and refactoring
profile_bluesky/startup/instrument/devices/usaxs_motor_devices.py:# TODO: fix the set_lim() method
profile_bluesky/startup/instrument/plans/area_detector.py: yield from bp.count([det], md=_md) # TODO: SPEC showed users incremen
profile_bluesky/startup/instrument/plans/axis_tuning.py: m_stage.r2p.tuner = empty_plan # TODO: should mimic TuneAxis()?
profile_bluesky/startup/instrument/plans/command_list.py: yield from bps.null() # TODO: remove this once you add the "other stuff"
profile_bluesky/startup/instrument/plans/command_list.py: except Exception: # TODO: XLRDError
profile_bluesky/startup/instrument/plans/command_list.py: # TODO: all these should accept a `md` kwarg
profile_bluesky/startup/instrument/plans/mode_changes.py:# def mode_SBUSAXS(): # TODO:
profile_bluesky/startup/instrument/plans/mode_changes.py: # TODO: need completion indication
profile_bluesky/startup/instrument/plans/mode_changes.py: yield from bps.sleep(0.5) # TODO: needed now?
profile_bluesky/startup/instrument/plans/scans.py: # TODO: install suspender using usaxs_CheckBeamStandard.get()
profile_bluesky/startup/instrument/plans/scans.py: # TODO: install suspender using usaxs_CheckBeamStandard.get()
profile_bluesky/startup/instrument/plans/scans.py: # TODO: what to do with USAXSScanUp?
profile_bluesky/startup/instrument/plans/scans.py: # TODO: make this link for side-bounce
profile_bluesky/startup/instrument/plans/scans.py: # TODO: what to do with USAXSScanUp?
profile_bluesky/startup/instrument/plans/scans.py: # TODO: make this link for side-bounce
profile_bluesky/startup/instrument/plans/scans.py: saxs_det.hdf1.stage_sigs = old_det_stage_sigs # TODO: needed? not even useful?
profile_bluesky/startup/instrument/plans/scans.py: waxs_det.hdf1.stage_sigs = old_det_stage_sigs # TODO: needed? not even useful?
profile_bluesky/startup/instrument/plans/tune_guard_slits.py: user_data.spec_scan, str(RE.md["scan_id"]+1+1), # TODO: Why SCAN_N+
profile_bluesky/startup/instrument/plans/uascan.py: # TODO: anything else?
profile_bluesky/startup/instrument/plans/uascan.py: trd.kind = "hinted" # TODO: correct value?
profile_bluesky/startup/instrument/plans/uascan.py: I00.kind = "hinted" # TODO: correct value?
profile_bluesky/startup/instrument/plans/uascan.py: I000.kind = "hinted" # TODO: correct value?
profile_bluesky/startup/instrument/plans/uascan.py: obj.kind = "normal" # TODO: correct value?
profile_bluesky/startup/instrument/plans/uascan.py: obj.user_setpoint.kind = "normal" # TODO: correct value?
profile_bluesky/startup/instrument/plans/uascan.py: obj.user_readback.kind = "hinted" # TODO: correct value?
profile_bluesky/startup/usaxs_support/bs_sfd_100.py:# TODO: inspect data types here
profile_bluesky/startup/usaxs_support/saveFlyData.xsd: <!-- TODO: <xs:enumeration value="hard" /> -->
profile_bluesky/startup/usaxs_support/saveFlyData.xsd: <!-- TODO: <xs:enumeration value="soft" /> -->
profile_bluesky/startup/usaxs_support/saveFlyData.xsd: <!-- TODO: <xs:enumeration value="external" /> -->
profile_bluesky/startup/usaxs_support/saveFlyData.xsd: <!-- TODO: <xs:attribute name="external_file" use="optional" default="xs:NMTOKEN
bash-4.2$ git grep FIXME:
profile_bluesky/startup/instrument/devices/usaxs_fly_scan.py: # FIXME: hack to avoid `Another set() call is still in progress
profile_bluesky/startup/instrument/devices/usaxs_motor_devices.py:# FIXME: https://github.com/APS-USAXS/ipython-usaxs/issues/341
profile_bluesky/startup/instrument/plans/sample_transmission.py: # FIXME: this failed when USAXS was already in position
What other local code overrides are now implemented by the new updates?
Originally posted by @prjemian in https://github.com/APS-USAXS/ipython-usaxs/issues/469#issuecomment-749121689