Closed prjemian closed 2 years ago
I have been looking at linkam.py and various user plans we have and I am more and more confused. My recollection is, that we had two support versions. I cannot figure this all out as I think I see only one support version, linkam.py. Does this one needs to be modified still? I need to make sure only one version is available (new one) and user plans are all converted or deleted.
This will happen with installation of new release (1.6.0rc5+) of apstools.
New support in apstools 1.6.0 (https://github.com/BCDA-APS/apstools/pull/560 and https://github.com/BCDA-APS/apstools/pull/625)
Note, to make linkam.ramp.get()
consistent for the two different devices, make a common alias in each:
# make a common term for the ramp rate (devices use different names)
linkam_ci94.ramp = linkam_ci94.rate
linkam_tc1.ramp = linkam_tc1.ramprate
Note
inposition
, use linkam.temperature
yield from bps.mv(linkam.temperature, value)
inposition
, use linkam.temperature.setpoint
yield from bps.mv(linkam.temperature.setpoint, value)
I hope this plan will be much easier to edit: https://github.com/APS-USAXS/ipython-usaxs/blob/87ec787bb2cad97eb2a00ebb7abf99e7f7f5ba18/user/heater_profile.py#L202-L218
See also #482
Instances of "linkam" (case-independent) in the repo now:
Updating the issue description above with the list of files.
Related problems appeared in these issues, (#484, #485, #487, #490). Time to rebuild this support and make it rely on common tools that any APS beam line can use.
Make sure that the same support can be used at other beam lines.
Look at PTC10, Linkam, Lakeshore, and others. (4ID-Polar and 8IDI)
repository files affected
examples/README.md
examples/custom_loop.md
examples/use_linkam.md
profile_bluesky/startup/instrument/devices/__init__.py
profile_bluesky/startup/instrument/devices/general_terms.py
profile_bluesky/startup/instrument/devices/linkam.py
profile_bluesky/startup/usaxs_support/heater_profile_manager.sh
profile_bluesky/startup/usaxs_support/heater_profile_process.py
profile_bluesky/startup/usaxs_support/saveFlyData.xml
profile_bluesky/startup/usaxs_support/surveillance.py
user/README.md
user/heater_profile.py
user/linkam.py
user/localfile.py
user/old/fz_linkam.py
user/old/james_linkam.py
user/old/james_linkam2.py
user/old/linkam.py
user/old/linkam_new.py