search

APS-USAXS / usaxs-bluesky-ended-2023

Bluesky instrument for USAXS
0 stars 0 forks source link

coordinate scalers during SAXS & WAXS #572

Closed prjemian closed 1 year ago

prjemian commented 1 year ago
prjemian commented 1 year ago

Just the SAXS plan is refactored. We'll need to test for the problem with the scalers. Once that is cleared, we can refactor the WAXS plan in the same style.

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 0c25f48f2625091d9193a5c45e4b9b4f6dd9d570 into a803031b8c806c74949ff53fab1ef4cc3cb2f678 - view on LGTM.com

new alerts:

jilavsky commented 1 year ago

I like the recasting of the SAXS code. Looks lot more logical and cleaner. Let's try it tomorrow, if possible.

prjemian commented 1 year ago

For the suspender, by removing the white beam suspender, we also removed the 100sec delay and hook to start feedback. Can we add the hook which starts feedback before the 100sec delay in the BeamInHutch and then run the 100sec delay? I think that is the logical thing...If you get beam back, start feedback and run feedback for 100 seconds.

Since removing the suspender has additional consequences that venture outside the realm of #568, I plan to revert commit 0c25f48 and make all the the suspender changes as part of a PR based on #566 & #570.

prjemian commented 1 year ago

Resolved by changing the 9idcLAX:userTran1 parameters.