search

APSIMInitiative / APSIM710

APSIM
https://www.apsim.info
30 stars 47 forks source link

Sugar Module to DotNet #1082

Closed ApsimBot closed 5 years ago

ApsimBot commented 5 years ago

Legacy Bug ID: 1635 Author: Shaun Date: 2013-01-10 13:15:38 +0000 UTC

STEP 1: PROPOSAL Short description of the concept or proposed improvements (describe the problem): Work is currently underway to port the current sugar model into the DotNet framework. 

Rationale and Justification (why is this problem important):
The sugar model is in FORTRAN in it's own code base.  It was never even ported into plant but remained in it's own form. The model will be more maintainable and extensible if it is ported to a modern language. Failed attempt at porting to Plant2 means now just porting it as a separate module but now in modern C# language instead of FORTRAN.

Details of the proposed improvements (how you want to fix it):
Straight port of the old module. Basically just a change of languages so that all the functionality of the old module will be reimplemented in the new module. This is more of a software engineering problem. A change of language and component interfaced used.

Implications for users (how will this particular fix help):
This will make it compatible with the new Fast Apsim (when it arrives)

It will make debugging the module easier (thanks to the built in Visual Studio debugger) , which in turn makes fixing bugs and making improvements to the module easier.

Reviewer:
Geoff Inman-Bamber

Review Panel Contact:
Graeme Hammer

Supporting documentation (optional):
See Task ID:  1263

http://www.apsim.info/bugtracker/edit_bug.aspx?id=1263

for failed Sugar to Plant2 conversion.
ApsimBot commented 5 years ago

Author: ver078 Date: 2015-08-06 13:03:00 +0000 UTC

This port from Fortran to DotNet (in Apsim Classic) was completed by June 2013.

This DotNet version has since been ported over to ApsimX (aka Apsim Next Generation).

The only thing left to do on the ApsimX version is convert the Validation set over to ApsimX and test the port out on this Validation DataSet. Which I intend to do this financial year 2015/16.

Since the DotNet version that was in Apsim Classic was never approved for release in the official Apsim Classic release, once I had ported the DotNet version from Apsim Classic to ApsimX, the DotNet version in Apsim Classic was deleted to remove clutter from the version control system. See Task ID:  2027 

https://www.apsim.info/BugTracker/edit_bug.aspx?id=2027

This was done with Dean's approval. 

The idea is that now, this financial year to get the DotNet version in ApsimX Validated and submitted to the review panel for release as part of the official release of ApsimX. The old fortran version of the sugar module will remain the offical sugar module for the old Apsim Classic.