APSIMInitiative / APSIM710

APSIM
https://www.apsim.info
31 stars 47 forks source link

Make BD, KS, SAT, DUL, LL15 and cropLL settable #1420

Closed ApsimBot closed 5 years ago

ApsimBot commented 5 years ago

Legacy Bug ID: 1990 Author: Shaun Date: 2014-11-27 14:51:58 +0000 UTC

Hi Shaun

Just a heads up on a job for you. You may already know that Peter T and Jody are wanting some variables to be settable - see below. At first glance this seems straight forward but I suspect the crop models only read crop LL, DUL etc once at the beginning of the simulation and assume it won't change. Also we need to think about the implications of changing BD - this may have implications on other processes that assume BD won't change.

I'll call you later today about this.

Regards
Dean

On 18/11/2014 8:24 AM, Jody Biggs wrote:

Hi Dean

I hope you are well and are getting some of this rain!

I understand that PeterT has discussed with you last week getting some parameters added to the 'settable' list.

I have written a Manager2 script that does all the calculations so the next thing is to set the new values for the parameters.
These include:SAT, DUL, LL15, KS, OC, BD (and maybe wheat LL to start with???)

Also, I currently cannot read in the user supplied values for KS.
And looking a bit ahead it might also be useful to read in the clay, silt and sand parameters in the Soil-Analyses node.

Cheers

--

Jody Biggs

Research Project Officer

Agriculture Flagship

CSIRO

Ejody.biggs@csiro.au T+61 7 3833 5704 M0432 882 166

GPO Box 2583, Brisbane, Q4001

www.csiro.au | www.csiro.au
ApsimBot commented 5 years ago

Author: rcichota Date: 2014-11-27 15:00:00 +0000 UTC

If you're allowing the value of LL for crops to be changed dynamically, could we have XF also as a settable value?

This will actually contribute to the same work, but on a different stream...
ApsimBot commented 5 years ago

Author: har297 Date: 2014-11-27 15:18:00 +0000 UTC

This is scary stuff. I hope some pretty rigorous checking is done to ensure internal consistency of the soil parameters If you change BD and SAT then SWCON may need to change for instance. I am sure there are more parameters that have some associations too. Anyway the main point is that the parameters still configure the class and texture of the soil they are meant to represent. Anyway PT knows more about this than I do. Users (inexperienced and experienced) need to be confident that the parameterisation doesn't go silly.

ApsimBot commented 5 years ago

Author: zur003 Date: 2014-11-27 15:33:00 +0000 UTC

Rogerio - in the Plant module, I committed changes to make LL, XF and KL settable back in March (R3322).

ApsimBot commented 5 years ago

Author: ver078 Date: 2014-12-09 13:09:00 +0000 UTC

This has now been added to version control (See the links below)

 

                Delete

                ver078

                JodyBiggsChange

                Make BD, KS, SAT, DUL, LL15 settable

                T1990

                Win32:Pass (xml)

                lnx64:Queued

                27/Nov/2014 2:53 PM

                38min

                R3592

                Binaries BuildTree WindowsInstaller
                WindowsInstallerFull
                Win32 SFX
                Win64 SFX