search

APSIMInitiative / APSIM710

APSIM
https://www.apsim.info
30 stars 47 forks source link

The variable SoilType in soil (use in SoilN) is too short #1677

Closed ApsimBot closed 5 years ago

ApsimBot commented 5 years ago

Legacy Bug ID: 6234 Author: Rogerio Date: 2017-12-11 08:22:26 +0000 UTC

The variable SoilType is described in the UI as "Soil type, texture or other descriptor" and users have attempted add quite long descriptive names. However this variable is also used by SoilN to change some of its parameters (it needs specific words for that, defaults are used otherwise). As SoilN is a Fortran model, the string has a defined size (32 characters) and so APSIM crashes becouse of this, and the error message is not helpful for the user. This variable could simply be made larger to avoid errors.

It may be best to disconect the soil type decription and the key word for SoilN, but this is probably best addressed in ApsimX...
ApsimBot commented 5 years ago

Author: rcichota Date: 2017-12-11 09:11:00 +0000 UTC

I have increased the size to 120. this should have no implication for existing tests and users