search

APSIMInitiative / APSIM710

APSIM
https://www.apsim.info
32 stars 48 forks source link

FASW only takes into account SW of last two layers #2214

Open BrianCollinss opened 1 year ago

BrianCollinss commented 1 year ago

FASW only takes into account the water content of the last two layers of the rooting profile.

Is this intentional?

https://github.com/APSIMInitiative/APSIMClassic/blob/2dc1d3475e340e45da473f1daf5e66e98f448361/Model/Plant/Root/RootPart.cpp#L351

https://github.com/APSIMInitiative/APSIMClassic/blob/2dc1d3475e340e45da473f1daf5e66e98f448361/Model/Plant/Root/RootPart.cpp#L362-L370

It is not the same in NextGen:

https://github.com/APSIMInitiative/ApsimX/blob/9fb534a9772c45e680b3d4f0d88eef6931e179b2/Models/PMF/Organs/Root.cs#L363

BrianCollinss commented 1 year ago

@hol353 Hi Dean. May I please have your comment on this?

hol353 commented 1 year ago

I didn't write the root organ class in Next Gen so I have no idea why Next Gen is different to 7.10 in its calculation of FASW.