search

APSIMInitiative / APSIM710

APSIM
https://www.apsim.info
30 stars 47 forks source link

Field Pea model in Plant.Net #831

Open ApsimBot opened 5 years ago

ApsimBot commented 5 years ago

Legacy Bug ID: 1340 Author: Hamish Hamish Date: 2011-08-02 09:32:16 +0000 UTC

STEP 1: PROPOSAL

Short description of the concept or proposed improvements: Build a field pea model in APSIM.net to be put infront of the reference pannel for consideration to superseed old fieldpea model.

Rationale and Justification: There is currently a fieldpea model in the old plant templeate but this is only based on a single dataset and implemented in the old code base.  Field pea is an important crop in NZ rotations and we need a well validated and reliable pea model.  Field pea will also be the first legume module to be based on the new arbitrator module in Plant.NET and will be used as a test case. 

Details of the proposed improvements: FieldPea.xml will be translated into a Plant.NET paramaterisation.  Detailed datasets from NewZealand will be used to strengthen the paramaterisation and build a validation set.  Thus far we have collated the Roseworthy dataset (used for the original pea model), 3 field pea trials from the rainshelter at Lincoln and a sowing density trial from lincoln for this purpose.

Implications for users: Greater degree of confidence in the application of the field pea model.  All existing functionality will be maintained  

Reviewer:

Review Panel Contact: Greg McLean

Supporting documentation (optional):

ApsimBot commented 5 years ago

Author: murphy Date: 2011-08-31 14:44:00 +0000 UTC

Email sent to Hamish Brown on 31/08/11:

Dear Hamish,

I refer to APSIM Task ID 1340 - Field Pea model in Plant.Net http://www.apsim.info/BugTracker/sv-major_tasks.aspx?id=1340

The APSIM Initiative Reference Panel (RP) has approved the above task to proceed to Implementation (Step 3 in the attached document) subject to the following:

1) That the initial step be a strait port of the existing functionality into the Plant2 framework; and

2) Any new parameterisation or changes be treated separately and more detailed information should be provided for proper evaluation.

The next step is for you to undertake implementation of this improvement and provide all the relevant documentation (e.g. science , validation data, software code etc.). This will then be reviewed (Step 4) prior to final approval to incorporate the improvement into APSIM.

Greg McLean is the RP contact for this Task and would be happy to discuss the issue with you in more detail, particularly any issues you may have with the above approach..

Regards

Chris Murphy Principal Project Officer (APSIM)