Open HamishBrownPFR opened 7 years ago
I think it makes sense for micromet to calculate the potential (Eos) value. We did talk about this some time back. SWIM and Soilwat used to use the same code (duplicated) to do this (a bit silly really).
This may not be a simple job though – be ready for it to take longer than you expect.
From: Hamish Brown [mailto:notifications@github.com] Sent: Tuesday, 20 September 2016 2:10 PM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Huth, Neil (A&F, Toowoomba) Neil.Huth@csiro.au; Mention mention@noreply.github.com Subject: [APSIMInitiative/ApsimX] Have Microclimate deal with residues interception of precipitation and radiation (#1196)
I have just written some crappy code to get evaporation into the multi pore water model. I think SoilWat and Swim have their own internal calculations for doing this also. It would make sense to have a single method for calculating potential soil evaporation from the soil located in micro climate rather than duplicating this in every soil water model.
It would also tidy things up if we had microclimate deal with the effects of residues on interception of radiation and precipitation in microclimate as this is not handled well at the moment. I am happy to implement some stuff here but wanted to catch other peoples thoughts first.
Please discuss @hut104https://github.com/hut104 @hol353https://github.com/hol353 @zur003https://github.com/zur003 @rcichotahttps://github.com/rcichota @sno036https://github.com/sno036
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/1196, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALVK2lSbQyFRsWUZP9yZqaUF2a8VCGmAks5qr1ymgaJpZM4KBNJ7.
I agree that it makes sense for MicroClimate to calculate Eos but changing this has implications for soil temperature etc. but as Neil has pointed out this is a bigger job. Given that you've already got a work around for the pore stuff can we put this on hold until some other work progresses further? For example Neil and I were just talking about multizone/3-D systems and what that might mean for MicroClimate. Best to take a longer and well-considered approach here.
PS - do I have to add all the @'s in the comments?
I agree, but it is also good to fix these things when we are thinking about them and good to fix them now before APSIMX has much of a user base.
What about the residual interception does any one have thoughts on that.
you don't have to do the @'s if they are there once then they get notified of the thread
I've just talked to Neil about this.
Dean - if Russell and I move the EOS calculation from SoilWater to MicroMet will that affect what you're doing with refactoring SoilWater?
On 20/09/2016, at 5:15 PM, Hamish Brown notifications@github.com<mailto:notifications@github.com> wrote:
I agree, but it is also good to fix these things when we are thinking about them and good to fix them now before APSIMX has much of a user base.
What about the residual interception does any one have thoughts on that.
you don't have to do the @'s if they are there once then they get notified of the thread
� You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/1196#issuecomment-248203573, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALnLjX6_M8797HleFShr5GeU2yQ1gZXMks5qr2vpgaJpZM4KBNJ7.
@sno036 Some progress has been made toward resolving this issue but some discussion is needed to determine some of the details.
I have just written some crappy code to get evaporation into the multi pore water model. I think SoilWat and Swim have their own internal calculations for doing this also. It would make sense to have a single method for calculating potential soil evaporation from the soil located in micro climate rather than duplicating this in every soil water model.
It would also tidy things up if we had microclimate deal with the effects of residues on interception of radiation and precipitation in microclimate as this is not handled well at the moment. I am happy to implement some stuff here but wanted to catch other peoples thoughts first.
Please discuss @hut104 @hol353 @zur003 @rcichota @sno036