Closed hut104 closed 1 year ago
HamishBrownPFR
commented
8 years ago Is it even used for anything? I have got a feeling I put it in there when I was trying a few different things simulating potato N uptake but never did it properly. Could just be deleted?
hut104
commented
8 years ago I thought I tried deleting it some time back but had issues. We could try that first.
From: Hamish Brown [mailto:notifications@github.com] Sent: Tuesday, 20 September 2016 2:41 PM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Huth, Neil (A&F, Toowoomba) Neil.Huth@csiro.au; Author author@noreply.github.com Subject: Re: [APSIMInitiative/ApsimX] Length property of root class needs fixing (#1197)
Is it even used for anything? I have got a feeling I put it in there when I was trying a few different things simulating potato N uptake but never did it properly. Could just be deleted?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/1197#issuecomment-248199838, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALVK2qLREaPZWdUtEWd34KgnTz_6gHTfks5qr2PigaJpZM4KBNWq.
rcichota
commented
8 years ago I was checking how the plants uptake parameters were defined and found out that Potato uses the Root.Length in the function defining MaxDailyUptake. A search on APSIM folder show that it is used in two potato simulations as well as on Grapevine prototype, so it seems that if these are changed appropriately, than the Length can be deleted
The Length property of ZoneState has several problems.
1) it needs renaming as it is the total root length 2) It is the sum of root length densities currently rather than total root length (ie it is the sum of mm/mm^3) which makes no sense. Each layers RLD should be multiplied by layer thickness when summing.
I had suggested removing this entirely by having a public property which is the root length (mm/mm^2) vector.