search

APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
138 stars 167 forks source link

Creation of New SoilNutrient Model #1540

Closed hut104 closed 4 years ago

hut104 commented 7 years ago

A new model will be created with the aim to replace the soilN model in the longer term. It will provide a capacity to model C and N cycling, initially, with P and K cycling to be added later. It will be developed using approaches developed for PMF.

jbrider commented 5 years ago

refer to #3522

hut104 commented 5 years ago

@sarahcleary This now ready for review. I suggest Dr Valerie Snow (@sno036 ) as a potential reviewer.

sarahcleary commented 5 years ago

@APSIMInitiative/reference-panel - please note this for discussion in next meeting. If you have any comments or recommendations for reviewers, please provide these here prior to this meeting.

sarahcleary commented 5 years ago

@hut104 - as part of the review process, can you please provide a few sentences which will be used as part of the communications (news article/ResearchGate update) when ready for release?

sarahcleary commented 5 years ago

@hut104 - as per request above - can you please provide a few sentences which will be used as part of the communications (news article/ResearchGate update)? Once I've received this, we can commence the review process. The review will (or likely to) be conducted by @sno036 and @Keith-Pembleton

sarahcleary commented 5 years ago

@hol353 - please note action from last RP meeting - to discuss 'news release" paragraph with @hut104

hut104 commented 5 years ago

The Nutrient model replaces the Soil Nitrogen model within APSIM. The model is developed using similar infrastructure to that used in the crop models so that soil nutrient pools and fluxes can be described using the APSIM user interface. This should allow further development of the model by non-programmers and automation of soil nutrient model documentation.
The initial implementation reproduces the science within the APSIM Soil Nitrogen model. Enhancements, such as the incorporation of published approaches for BioChar, can be added in a relatively simple manner in later releases. The model has also been designed to assist the addition of other soil nutrients to the same modelling framework. For example, P cycling could be added to reproduce the SoilP model functionality with APSIM Classic.

sarahcleary commented 5 years ago

Thanks @hut104.
@Keith-Pembleton and @sno036 - as discussed, this model is now ready for review. As a trial, we are using the proposed process - solely via GitHub. Please refer to the Reviewer's Instructions and commence review: http://www.apsim.info/Documentation/TechnicalandDevelopment/ReviewersInstructions.aspx Please let me know if these Instructions need to be amended in anyway.

sno036 commented 5 years ago

Hi @hut104 - I have done a small comparison with a simple simulation of a cutting trial with AgPasture comparing Nutrient and SoilNitrogen and there is some weirdness going on with differring production, differing responses to fertiliser and a bizarre spike in no3 and minn that crashes on 7 Jan. Possibly there is something wrong with the comparison I've set up so see the zipfile attached.

image

image

NutrientAgPastureV1.zip

hol353 commented 5 years ago

@hut104 Can you respond to this please?

sarahcleary commented 5 years ago

@hut104 - have you responded to this?

hut104 commented 5 years ago

Sorry, I’ve been travelling and in workshops. I will try to resolve these before the end of the year.

From: sarahcleary notifications@github.com Sent: Wednesday, 23 October 2019 11:43 AM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Huth, Neil (A&F, Toowoomba) Neil.Huth@csiro.au; Mention mention@noreply.github.com Subject: Re: [APSIMInitiative/ApsimX] Creation of New SoilNutrient Model (#1540)

@hut104https://github.com/hut104 - have you responded to this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/1540?email_source=notifications&email_token=AC2UVWTY3DZ63WUBB7ZIU63QP6TYRA5CNFSM4DCOQNCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7XZKI#issuecomment-545225897, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC2UVWXOYTDXEKVAFXZ6YY3QP6TYRANCNFSM4DCOQNCA.

sarahcleary commented 4 years ago

@hut104 - any update?

hut104 commented 4 years ago

No progress. All efforts have been on other issues causing severe defects within the system unfortunately.

From: sarahcleary notifications@github.com Sent: Tuesday, 10 December 2019 10:47 AM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Huth, Neil (A&F, Toowoomba) Neil.Huth@csiro.au; Mention mention@noreply.github.com Subject: Re: [APSIMInitiative/ApsimX] Creation of New SoilNutrient Model (#1540)

@hut104https://github.com/hut104 - any update?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/1540?email_source=notifications&email_token=AC2UVWW3CP35W7VF5AZLFBTQX3RH5A5CNFSM4DCOQNCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGLHFJQ#issuecomment-563507878, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC2UVWW25GOAGWK4FOKM423QX3RH5ANCNFSM4DCOQNCA.

sarahcleary commented 4 years ago

@hut104 - any update?

sarahcleary commented 4 years ago

@hut104 - any update?

hut104 commented 4 years ago

Hope to complete during code sprint in NZ early March

From: sarahcleary notifications@github.com Sent: Tuesday, 25 February 2020 9:36 AM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Huth, Neil (A&F, Toowoomba) Neil.Huth@csiro.au; Mention mention@noreply.github.com Subject: Re: [APSIMInitiative/ApsimX] Creation of New SoilNutrient Model (#1540)

@hut104https://github.com/hut104 - any update?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/1540?email_source=notifications&email_token=AC2UVWTBTB6R2ADXQBZKFZTRERKWZA5CNFSM4DCOQNCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZ6KRQ#issuecomment-590603590, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC2UVWTQXRXC4VX5ZOFL47LRERKWZANCNFSM4DCOQNCA.

hut104 commented 4 years ago

Hi @sno036 This has been fixed. It was related to PlantAvailableNO3 and PlantAvailableNH4.

Hi @hut104 - I have done a small comparison with a simple simulation of a cutting trial with AgPasture comparing Nutrient and SoilNitrogen and there is some weirdness going on with differring production, differing responses to fertiliser and a bizarre spike in no3 and minn that crashes on 7 Jan. Possibly there is something wrong with the comparison I've set up so see the zipfile attached.

image

image

NutrientAgPastureV1.zip

sarahcleary commented 4 years ago

@sno036 and/or @hut104 - what is the next step?

hut104 commented 4 years ago

The issues raised by the review have been addressed. Awaiting further response prior to final release.

From: sarahcleary notifications@github.com Sent: Tuesday, 31 March 2020 10:16 PM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Huth, Neil (A&F, Toowoomba) Neil.Huth@csiro.au; Mention mention@noreply.github.com Subject: Re: [APSIMInitiative/ApsimX] Creation of New SoilNutrient Model (#1540)

@sno036https://github.com/sno036 and/or @hut104https://github.com/hut104 - what is the next step?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/1540#issuecomment-606590183, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC2UVWTKPXR34U3MWYXYJ33RKHNLBANCNFSM4DCOQNCA.

sarahcleary commented 4 years ago

@sno036 - this is with you now?

JJguri commented 4 years ago

I am trying to test the ability of the Nutrient model to predict different N scenarios using the sugarcane NG example (200 kgN/year in a 2000 mm/year environment). I got N in biomass through two outputs ([Sugarcane].plant_n_tot and [Sugarcane].biomass_n), which is the difference between them? root_n?. Then I got NO3 leaching and Nmineral through [Soil].SoilWater.LeachNO3 and [Nutrient].MineralN, respectively. Overall, NO3 was 40 times lower than N in biomass. I am trying to close the N cycle counting for N pools in runoff and losses to the atmosphere. For N2O or Natm I used [Nutrient].N2Oatm and [Nutrient].Natm but these pools are always equal to 0. I did not find a way to count for N pools in runoff yet. Do you know how can I make the model sensible to N losses to the atmosphere and runoff? @hut104 @sno036 @Keith-Pembleton

sarahcleary commented 4 years ago

ACTION from last RP Meeting: @sno036 to rerun the test. If this is positive, then fully approved. @sno036 - is this ready for approval/release?
@hut104, @Keith-Pembleton - question above from @JJguri