APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
134 stars 162 forks source link

Units for Maintenance respiration #3014

Open HamishBrownPFR opened 6 years ago

HamishBrownPFR commented 6 years ago

@byzheng I have been working with @Xiumei2017 on the lucerne model and find the handling of Maintenance respiration a little be clumsy. Currently I think you are the only one who has used this so interested in your opinion. Currently we calculate maintenance respiration as an absolute amount and divide it by the mass of the organ to convert it to a proportion in the MaintenanceRespirationFunction. Then we then multiply this by the organ mass in the code to convert it back to an absolute. Would you have any objections to changing this so the MaintenanceRespirationFunction gives respiration in an absolute amount.

byzheng commented 6 years ago

@HamishBrownPFR Not sure about your question. Could you point out the codes you are looking for? In my memory, Enli and I have discussed about MaintenanceRespirationFunction and mainly changed codes for units (CH2O or CO2). The original codes are not clear about which unit are used.

HamishBrownPFR commented 6 years ago

Thanks @byzheng. The units for MaintentanceRespirationFunction are neither CH2O nor CO2. It is a proportion of the parent organs wt.

Medium term I would like to integrate the Maintenance respiration into the IArbitration interface better. Currently the DMAllocation structure that is passed has a Respired member but respiration is passed through a separate RemoveMaintenanceRespiration method.

Anyway, my specific question was relating to the code below (from geneircOrgan.cs) where we have to multiply the maintenanceRespirationFunction.Value() by the organ wt to get an amount in g/m2. I am thinking it would be better if the maintenanceRespirationFunction.Value() was already in g/m2.

image

byzheng commented 6 years ago

@HamishBrownPFR About the unit of maintenance respiration, I will send an email to Enli and cc you for more information.