search

APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
136 stars 164 forks source link

'simple' changes/fixes required to SW data functionality #3319

Open AllanPeake opened 5 years ago

AllanPeake commented 5 years ago

(1) Ensure SW graph (that appears when you click on 'water' in soiltype) stays the same once you have manipulated the axes (2) Suggest automatically assigning maxvalue of x axis to 1.5 - will compress the graph to a more readable proportion i.e. as per screenshot image

(3) Initial water should be added to this graph. Also, shading is in the wrong place. Ideally want to shade area between initial water and CLL#1.

(4) Line colours should be changed: suggest as follows, not sure what is possible

(5) units for both N and water in 'initial water/N' need to be able to be toggled via right click of heading (thought we had already done this, may have been corrupted). N = mg/kg or ppm. Water = VWC or gravimetric WC

(6) Totals would be benefical in the initial water/N data columns Total N (kg/ha) Total PAW (vs CLL 1) Total Profile SW (vs zero)

hol430 commented 5 years ago

Do you want LL15 and Air Dry to be the same shade of orange?

AllanPeake commented 5 years ago

Yep I think so. Or they can be diff, no big deal

hol430 commented 4 years ago

Hi @AllanPeake, I have implemented (1), and am not sure that (2) is necessary given that you can apply this change yourself and have it persist now. I'm not sure how (3) will work if there is more than one crop - do we just maintain current behaviour in that case? (4) I can implement something that's not exactly what you asked for but should at least make it easier to distinguish between all of the different shades of blue which we have currently. (5) - we deliberately removed in order to make the UI more internally consistent. As for (6), I think we used to have the PAWC totals in the column headers, I'm not sure where they went. Will investigate.

AllanPeake commented 4 years ago

With (2) I think the default (prior to anyone setting it themselves) should definately be 1.5, to save us having to do it for ourselves. And it isn't persisting for me yet - I am using version 5133, perhaps you have fixed it in last couple of days

Re; (3) I would shade to the first CLL listed - or maybe LL15

(4) Just as long as 'hot' colours are on the low side and 'cold' colours on the full side. Dark Blue for DUL, light blue for PAW.

(5) I still reckon that was a really poor decision from a users perspective. It would be great if there were some way to implement this, or something similar. Maybe a standalone 'calculator' module that can plug in grav, convert automatically to vwc when plugged into the soil of choice. Could plug into the 'physical' node maybe. Needs some thought, this is really important functionality. Talk to me before trying to implement.

(6) Yep PAW totals would be nice somewhere. On the graph against each crop CLL would be amazing.

AllanPeake commented 4 years ago

Alternatively with (2) could make a slider bar to compress the window left to right, would be faster for user but perhaps more difficult to implement

rcichota commented 4 years ago

I am bit late on this discussion, but as the issue is still open I will add to it. I have not been able to use the latest versions o Apsim because the amount of changes (which is good to have, but not good if you have projects involving different people and that need some consistency in the tool used). I have now start to get many complaints about the some of the changes to the soil GUI. Improving the graphs as per above is going to make things a lot better. I second the use of the color scheme above, but agree that having a few LLs with the same colour will cause confusion. It would be great to have the tickboxes we had in Classic, only the first LL would be shown and the user could then easily select others. I was going to disagree with shading be based on LL instead of LL15. But on second thought I think that using LL has merits, I had users using LL wrongly too close to DUL and not noticing because the graphs shading implied a much bigger water availability... I do question the use of initial water for shading though. In fact I think on PhysicalProperties you want shading between DUL and LL/LL15. Whereas a similar graph but with shading using initial water should appear in the tab where initial water is defined...

rcichota commented 4 years ago

I continue with the rant, sorry. But I am also getting complaints about the auxiliary data we had in the GUI, and as I do some work with the newer version I fully agree. It was great to have a quick overview of totals (N and PAW), which is what most people are interested. moreover having PAW in mm/mm is not useful, people always use this in mm. And N in kg/ha... Having the ability to switch between ppm and kg/ha was great. one of my colleagues was quite annoyed having to do conversions before entering values in Apsim, and is now using an old version of Apsim to avoid that... Values of N in kg/ha are very common.

AllanPeake commented 4 years ago

Rogerio, they are great comments thankyou! I am glad I am not the only one frustrated with the changes (especially the last comment regarding ppm and kg/ha – a very important and needed conversion). I also agree with the need for quick overviews of PAW and N.

From: Rogerio Cichota notifications@github.com Sent: Friday, 29 May 2020 10:10 AM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Peake, Allan (A&F, Toowoomba) Allan.Peake@csiro.au; Mention mention@noreply.github.com Subject: Re: [APSIMInitiative/ApsimX] 'simple' changes/fixes required to SW data functionality (#3319)

I continue withe the rant, sorry. But I am also getting complaints about the auxiliary data we had in the GUI, and as I do some work with the newer version I fully agree. It was great to have a quick overview of totals (N and PAW), which is what most people are interested. moreover having PAW in mm/mm is not useful, people always use this in mm. And N in kg/ha... Having the ability to switch between ppm and kg/ha was great. one of my colleagues was quite annoyed having to do conversions before entering values in Apsim, and is now using an old version of Apsim to avoid that... Values of N in kg/ha are very common.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/3319#issuecomment-635682123, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIOWCTZS2OL4M2FM5QESRELRT34NBANCNFSM4GGAGZRA.

hol430 commented 4 years ago

@hol353 @hut104 - see above with regards to toggling between kg/ha and ppm in the gui. I think that removing the ability for the model to store these variables in different units was the right way to go, it was just a mess. That being said, I've done some testing and it wasn't too hard to get the UI to switch back and forth between ppm and kg/ha in the profile grids. Everything is handled at the UI level, so the model still only works with one set of units, but the UI can translate back and forth. This might be a good middle ground - let me know if you think it's a good idea and I can submit a PR.

hut104 commented 4 years ago

I think we touch base next week and talk it through carefully. Some of these things in Classic were really effective in allowing users to change things... in ways that had unintended consequences. APSoil grids took years off Dean's life.

From: Drew Holzworth notifications@github.com Sent: Friday, 9 October 2020 2:53 PM To: APSIMInitiative/ApsimX ApsimX@noreply.github.com Cc: Huth, Neil (A&F, Toowoomba) Neil.Huth@csiro.au; Mention mention@noreply.github.com Subject: Re: [APSIMInitiative/ApsimX] 'simple' changes/fixes required to SW data functionality (#3319)

@hol353https://github.com/hol353 @hut104https://github.com/hut104 - see above with regards to toggling between kg/ha and ppm in the gui. I think that removing the ability for the model to store these variables in different units was the right way to go, it was just a mess. That being said, I've done some testing and it wasn't too hard to get the UI to switch back and forth between ppm and kg/ha in the profile grids. Everything is handled at the UI level, so the model still only works with one set of units, but the UI can translate back and forth. This might be a good middle ground - let me know if you think it's a good idea and I can submit a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/APSIMInitiative/ApsimX/issues/3319#issuecomment-705966702, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC2UVWSGDOF2HVMAAEYQKJLSJ2JMLANCNFSM4GGAGZRA.