APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
132 stars 161 forks source link

APSIM downloads database clean-up #3923

Closed hol353 closed 5 years ago

hol353 commented 5 years ago

I have just tried to work with the APSIM downloads database to generate a downloads map by country. Problems that I encountered:

hol430 commented 5 years ago

Why do we collect state/city/street address info from the registration form? Can this be removed altogether?

hol353 commented 5 years ago

@sarahcleary Do we still need to collect address information from users when they download APSIM. We never use the information for anything.

sarahcleary commented 5 years ago

We need country and email address. We may need additional information when setting up the click-wrap commercial license.

hol353 commented 5 years ago

Yes I agree we need country and email address but what about street address, city etc? Can we remove them?

sarahcleary commented 5 years ago

OK to remove

hol430 commented 5 years ago

Do we want some way to distinguish between upgrades (via apsimx upgrade form) and registrations (via web form)?

zur003 commented 5 years ago

I would think we'd want to be able to distinguish new registrations from upgrades. It would make it easier to estimate the actual number of distinct users.

sarahcleary commented 5 years ago

Agreed - if possible

hol430 commented 5 years ago

We can currently download the registrations database in .csv format via a public-facing web service. Should this .csv file omit sensitive information such as name/email?

sarahcleary commented 5 years ago

yes

hol430 commented 5 years ago

Ok I've addressed all of the issues raised in this thread and have cleaned up all of the country entries in the database. Anyone using an old version of apsim will still be using a text entry for country and so will still be able to submit a non-standard country name. To work around this, I've changed the registrations web service to ignore any requests with an invalid country.

I've also finished up that python script you sent me to generate a map of downloads by country. Source code is here.

apsim-downloads