search

APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
129 stars 159 forks source link

Port the maize model from Apsim 7.10 into Next Gen #4521

Open hol430 opened 4 years ago

hol430 commented 4 years ago

The Maize module in APSIM Classic is being ported to PMF as a temporary new entity (C4Maize) so that it can be fused with the temporary existing Maize module to form one comprehensive maize module in APSIMX . It brings a more explanatory approach to the modelling of the underlying physiology of the plant and enables linkage to a range of (optional) more detailed process modules (canopy photosynthesis and transpiration, grain set and abortion) developed with the APSIM Classic version. It incorporates the dynamics of plant N based on the amount of leaf N per unit leaf area (specific leaf nitrogen [SLN]) that is closely aligned with plant growth processes, links directly to leaf photosynthetic processes, and is independent of growth stage.

Linkages to the detailed and optional photosynthesis and transpiration routines, and the grain set and abortion module will be incorporated once the base module has passed review.

HamishBrownPFR commented 4 years ago

Would be good to clarify the intent here please.

jbrider commented 4 years ago

@Hamish Brown Hamish.Brown@plantandfood.co.nz We're bringing the old maize model across as a new entity in the first instance as it is based very closely on the sorghum code. Following this will be the new DCaPS photosynthesis model, a limited transpiration model, and a grain abortion model that were all developed on this code base.

The goal is to merge all of this into 1 maize model eventually, but I don't really understand the differences in the science quite well enough to know how easy or hard this may be at this point. However that is managed will require the old model to be brought into the new framework in order to utilise the testing system to know what effect changes will have - the system used in ApsimClassic is not effective. The easiest way will to do that will be to put this work in the UnderReview folder as all changes are tested on the models there. The new model is now giving the same results as the old one - Drew has got that working really quickly.

On Thu, Dec 12, 2019 at 10:56 AM Hamish Brown notifications@github.com wrote:

Would be good to clarify the intent here please.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/APSIMInitiative/ApsimX/issues/4521?email_source=notifications&email_token=AAE3G7GMUW2GQRRL4M2JDSTQYGD4TA5CNFSM4JZWDJ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGVC3JA#issuecomment-564800932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE3G7CKHNJBIUNCWLXWTTTQYGD4TANCNFSM4JZWDJ5Q .

HamishBrownPFR commented 4 years ago

@jbrider thanks for the clarification here. This is a good step toward harmonizing the different approaches.