APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
138 stars 167 forks source link

Soils Interface Issues #7454

Closed jbrider closed 1 year ago

jbrider commented 2 years ago

I found these issues while looking for a simple example of a variety of locations for the sorghum release. I found a couple in Chickpea for Katherine and Launceston which seemed like a good place to start. Both locations use the same derived sandy soil that appears worse than the sandy soils in WA.

Physical Node within a soil

Download a soil

Error resolving type specified in JSON 'Models.Soils.InitialWater, Models'. Path 'Children[0].$type', line 25, position 50. --> Could not find type 'Models.Soils.InitialWater' in assembly 'Models, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'.
Duplicate models found: ~paddock.Synthetic Soil Derived from ISRIC SoilGrids has 2 children named Water

I haven't recreated this on another machine, but I have verified similar behaviour across multiple files. Manually editing the file finds that it had made copies of the Water, NO3, NH4 and Urea nodes.

Soil Specific

After removing them, I am getting a strange graph that doesn't show the entire profile - just the top 1400mm. image This is shown more dramatically in the slightly wider graph within the Water node: image I see the read only (calculated?) SW field is set to 0 in the bottom 3 layers - but not sure what is causing them to affect DUL but not Airdry - hopefully it is a visual thing only? Where they start is also odd - around the 250mm point. Other graphs are displaying from the end of the first layer which would be 150mm?

jbrider commented 2 years ago

It looks like the error pasting has nothing to do with the soil downloading. See: #7425

Chloe0317 commented 2 years ago

I ran into the same error code when trying to download a soil in one simulation

Error resolving type specified in JSON 'Models.Soils.InitialWater, Models'. Path 'Children[0].$type', line 25, position 50. --> Could not find type 'Models.Soils.InitialWater' in assembly 'Models, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'.

Then in another simulation, an error about not able to download SLGA synthetic soil appeared as

Cannot get data from https://www.asris.csiro.au/ASRISApi/api/APSIM/getApsoil?longitude=150&latitude=-31.52

Though this error seems to be transient and when I tried to replicate it, it reverted to the first error. It seems that the option to download the SLGA synthetic soils in Next Gen is disabled. I would assume based on the data sources it may be more accurate than ISRIC soils for Australia @hol353 what might be the reason for not including it please? Thanks heaps!

hol353 commented 2 years ago

Yes there seems to be several defects dealing with downloading / editing soils. SLGA would be better than ISRIC for Australia. APSoil is probably better than SLGA though depending on what you're trying to do.

hol353 commented 2 years ago

@her123 Can you look at the 'Download a soil' issues?

her123 commented 2 years ago

@hol353 can you check the changes I made in the pull request. The remaining part of this issue may be for your attention.