APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
130 stars 160 forks source link

StageBasedInterpolation should use a grid for input parameters #9091

Open HamishBrownPFR opened 2 months ago

HamishBrownPFR commented 2 months ago

Describe the new feature

Currently inputs to StageBasedInterpolation are a series of comma seperated values that correspond to the values at each stage. It is very easy to get things wrong here and it is necessary to add a dummy value at the start to get values to align because the values are extracted with zero based indexing in the code. Would be better to implement a grid with a row for each phenological stage and fix the indexing in the background so it is clear to the user what value is being used by the model.

HamishBrownPFR commented 2 months ago

After thinking on this a bit more I have changed the title of the issue and the suggested response. StagebasedInterpolation is not used much as linInt can be used in its place.
We should deprocate StagebasedInterpolation and convert anything that is currently using to linints