Open hrpasl opened 3 months ago
Having a manager script in the release that makes it easier to change these things makes me uncomfortable. Too many users already change things they shouldn't just to better fit their data. They don't feed these modifications back to us (a breach of their APSIM licence!) for peer-review. If a user changes any of the things you mention, then the nutrient model they are using won't be validated.
There are times of course when you have a project (like what you have @hrpasl and @KirstenVer have) that needs to do new science to try and come up with better approaches for mineralisation, nitrification etc. This is a valid thing to do.
So, happy for you to have a manager script but maybe not in the release.
BTW, I wonder if we could just use an operations that simple lists the things you want to change.
Describe the new feature
• Prepare manager script example that allows changes to default parameters of Nutrient model, including front page or drop down menu to encourage people to only make changes to a subset of all possibilities and any code changes to allow parameters to be set—to share with other researchers who are reluctant to change over to Next Generation Based on the N Model Review, the following parameters were changed the most frequently: • Microbial Decomposition Rate PotentialRate TrueValue • Humic Decomposition Rate PotentialRate TrueValue • Denitrification N2Ofraction Gas diffusivity in soil at field capacity • Optimum and base temperature temperature factor (mineralisation and nitrification) • Water factor mineralisation • Nitrification Rate Potential Nitrification Rate and Concentration at Half Max • Nitrification N loss