search

APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM
http://www.apsim.info
Other
132 stars 161 forks source link

Checking inputs for simulation #9260

Open femiguez opened 3 weeks ago

femiguez commented 3 weeks ago

Describe the new feature

There are probably several inputs which are not being checked to ensure that they are within biophysically reasonable bounds. As an example, I'm attaching the Wheat example file with values of SWCON (SoilWat) which are greater than 1. This, as I understand it, is the proportion of water moving from one layer to the next, so it can't be greater than one. The simulation runs without complain, but it should, as much as possible return an error. There are probably other inputs which are not being checked and I understand if it might be a daunting task to check for all parameters and variables, but I think adding these checks will be an important improvement. If you leave this issue open I can include examples and document other inputs or parameters which are not being checked and do not result in errors. Wheat_high_SWCON.apsimx.zip

femiguez commented 3 weeks ago

Other examples:

Organic

1) Soil organic carbon being above 100% or below zero 2) Fbiom + Finert for a given layer being greater than 1 3) FOM being negative

Surface Organic Matter

1) Mass of initial residue of less than zero 2) A negative C:N returns an error: "SurfaceOM - N decomposition exceeds potential rate". It should check the input values instead.