NH4 when specified as an amount is not being added to SurfaceOrganicMatter

APSIMInitiative / ApsimX

ApsimX is the next generation of APSIM

http://www.apsim.info

Other

138 stars 167 forks source link

NH4 when specified as an amount is not being added to SurfaceOrganicMatter #9264

Open sno036 opened 2 months ago

sno036 commented 2 months ago

What happened?

For some reason the logic around NH4 was done differently to NO3 and that resulted in the NH4 not being added.

There are other issues (to be fixed later)

no amount option for P
the wrong amount of C is being added or the reporting is wrong

What Operating System are you on?

Windows

sno036 commented 2 months ago

NH4 sorted with the pull request above but I'll need some assistance sorting some of the other issues. See attached simulation.

2005-01-05 [SurfaceOrganicMatter].AddFaeces(organicC: 1000, organicN: 100, no3N: 50.0, nh4N: 50, p: 0.0) is adding 200 kg N for some reason. Might be a reporting error perhaps?

testSlurry.zip

sno036 commented 2 months ago

Just reopening because I think there are also issues in the carbon - but the immediate need for the fix for NH4 has now been merged.