search

APSIMInitiative / ReferencePanel

2 stars 2 forks source link

RP Meeting - 3 August 2021 #91

Open sarahcleary opened 3 years ago

sarahcleary commented 3 years ago

Review of Peanut Model - https://github.com/APSIMInitiative/ApsimX/issues/4075

@hut104 to present

@APSIMInitiative/reference-panel - Please let me know if you have suggestions for additional attendees.

@APSIMInitiative/steering-committee - FYI. If you would like to attend, please let me know and I'll forward the meeting invitation.

Information for Developer

Information for Reviewers

sarahcleary commented 3 years ago

@sarchontoulis unable to attend meeting. Fernando Miguez has been invited to attend from ISU.

yashvirchauhan commented 3 years ago

Graeme Hammer (Graeme Hammer pioneered the initial Qnut model on which APSIM peanut model was based). Graeme Wright From PCA (email: @.) RCN Rachaputi from UQ @*.**@*.>). Has worked for a long time on peanuts. Mike Bell @*.**@*.***>): Mike provided considerable data that were used in calibrating peanut cultivars and also various parameters including radiation and water use efficiency.

From: sarahcleary @.***> Sent: Wednesday, 9 June 2021 12:24 PM To: APSIMInitiative/ReferencePanel Cc: CHAUHAN Yash; Team mention Subject: [APSIMInitiative/ReferencePanel] RP Meeting - 3 August 2021 (#91)

Review of Peanut Model - APSIMInitiative/ApsimX#4075https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_APSIMInitiative_ApsimX_issues_4075&d=DwMFaQ&c=tpTxelpKGw9ZbZ5Dlo0lybSxHDHIiYjksG4icXfalgk&r=hiah2sQ-CTvEKWphP2lg1VtBYbiu1BBh7b-5ODk0KFI&m=vE-Hvq7PZ4hdCMphX5R86EUkDH6TEzKpagZ2TKdBcuY&s=J5UEU6taNR9V1OhMXTMfXjTtOY8rW7EuE_YHKmVCIRg&e=

@hut104https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hut104&d=DwMFaQ&c=tpTxelpKGw9ZbZ5Dlo0lybSxHDHIiYjksG4icXfalgk&r=hiah2sQ-CTvEKWphP2lg1VtBYbiu1BBh7b-5ODk0KFI&m=vE-Hvq7PZ4hdCMphX5R86EUkDH6TEzKpagZ2TKdBcuY&s=-wmHLyUsXeZhz0AktRh5oOkZ4fOknxCwaSknEY3UlyE&e= to present

@APSIMInitiative/reference-panelhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_orgs_APSIMInitiative_teams_reference-2Dpanel&d=DwMFaQ&c=tpTxelpKGw9ZbZ5Dlo0lybSxHDHIiYjksG4icXfalgk&r=hiah2sQ-CTvEKWphP2lg1VtBYbiu1BBh7b-5ODk0KFI&m=vE-Hvq7PZ4hdCMphX5R86EUkDH6TEzKpagZ2TKdBcuY&s=ePOe4rhCvFgUdqtgnvUzaHII6ILGlZLdUhw7ley5VUA&e= - Please let me know if you have suggestions for additional attendees.

@APSIMInitiative/steering-committeehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_orgs_APSIMInitiative_teams_steering-2Dcommittee&d=DwMFaQ&c=tpTxelpKGw9ZbZ5Dlo0lybSxHDHIiYjksG4icXfalgk&r=hiah2sQ-CTvEKWphP2lg1VtBYbiu1BBh7b-5ODk0KFI&m=vE-Hvq7PZ4hdCMphX5R86EUkDH6TEzKpagZ2TKdBcuY&s=H6DHN2B4jXb8iiaoaKJqjxei4Vb8AnUArmFumSM_I_M&e= - FYI. If you would like to attend, please let me know and I'll forward the meeting invitation.

Information for Developer

Information for Reviewers

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_APSIMInitiative_ReferencePanel_issues_91&d=DwMFaQ&c=tpTxelpKGw9ZbZ5Dlo0lybSxHDHIiYjksG4icXfalgk&r=hiah2sQ-CTvEKWphP2lg1VtBYbiu1BBh7b-5ODk0KFI&m=vE-Hvq7PZ4hdCMphX5R86EUkDH6TEzKpagZ2TKdBcuY&s=c701Qy13iYNKbWr-Kf73P3eX8YJ-XObqNZxk14melrE&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKG7ITZYWXVRCZW42S26PQDTR3GCZANCNFSM46LDLMQQ&d=DwMFaQ&c=tpTxelpKGw9ZbZ5Dlo0lybSxHDHIiYjksG4icXfalgk&r=hiah2sQ-CTvEKWphP2lg1VtBYbiu1BBh7b-5ODk0KFI&m=vE-Hvq7PZ4hdCMphX5R86EUkDH6TEzKpagZ2TKdBcuY&s=RDp38px_RPzxfp0leSDOKsypCSzpuoTI-Fd6zY9Fph8&e=.

The information in this email together with any attachments is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. There is no waiver of any confidentiality/privilege by your inadvertent receipt of this material. Any form of review, disclosure, modification, distribution and/or publication of this email message is prohibited, unless as a necessary part of Departmental business. If you have received this message in error, you are asked to inform the sender as quickly as possible and delete this message and any copies of this message from your computer and/or your computer system network.

sarahcleary commented 3 years ago

thanks @yashvirchauhan - can you please send me these emails directly. @uqghamme - I'll forward you the meeting invite

sarahcleary commented 3 years ago

@femiguez

sarahcleary commented 3 years ago

Please note presentation can be accessed here - https://github.com/APSIMInitiative/ApsimX/issues/4075#issuecomment-889610954

sarahcleary commented 3 years ago

Apologies from @MarkLieffering

sarahcleary commented 3 years ago

Apologies from @JulianneLilley

jbrider commented 3 years ago

Some graph issues... Kingaroy8384

Kunnunara8283

.Simulations.Validation.Australia.Loxton9697.Growing Season Mean Air Temperature

.Simulations.Validation.Australia.Loxton9697.TimeSeries.NodeNumber

.Simulations.Validation.Australia.Loxton9697.TimeSeries.LAI1

.Simulations.Validation.USA.Gainsville EarlyBunch.TimeSeries.StemMass with components

LouisAK commented 3 years ago

A minor comment re the pdf document... countries boundaries are missing on the map (section 4.1 P36)

sarahcleary commented 3 years ago

2021-08 Minutes

Attendees:

@LouisAK; @hol353; @peter-devoil; @yashvirchauhan; @sarahcleary; @jbrider; @hut104; @sno036; @EnliWang; @kchenu; @Keith-Pembleton; @femiguez

Tuesday 3rd August 2021 - 9:30 am AEST

Meeting recorded – which can be accessed on Teams link for meeting attendees. Any issues, please contact @sarahcleary directly. Review of Peanut Model - https://github.com/APSIMInitiative/ApsimX/issues/4075 @hut104 ran through the powerpoint – Peanut Model Reference Panel.pptx

Discussion can be found on recording. Please email apsim@csiro.au if you wish to have access.

Agreed that Peanut model should be progressed into release. @hol353 to complete.

Additional Actions (but not needed prior to release). @sno036 to provide @hut104 with local experimental data to enable a further sensibility test.
@Keith-Pembleton to follow up Mark Peoples with regard to Nitrogen experiments @kchenu proposed powerpoint slides to be part of Autodoc. No direct action from this due to the nature of the autodocumentation.

Also agreed that chickpea should be released https://github.com/APSIMInitiative/ApsimX/issues/158. @yashvirchauhan to follow up with @AllanPeake directly with regard to experimental data and model fit.

hut104 commented 3 years ago

Phenology -> Predicted EmergenceDAS doesn't have any observed values and only 1 of 3 cultivars show values (same emergence?) TimeSeries -> Biomass -> TMax line not present in legend - this happens in a few charts .Simulations.Validation.Australia.Loxton9697.Growing Season Mean Air Temperature series1 has no name .Simulations.Validation.Australia.Loxton9697.TimeSeries.NodeNumber EventNames added but not appearing on graph .Simulations.Validation.Australia.Loxton9697.TimeSeries.LAI1 LAI1 seems to be a repaet of LAI - except event names are working .Simulations.Validation.USA.Gainsville EarlyBunch.TimeSeries.StemMass with components components aren't named

@jbrider I think these are just in the Json file rather than the PDF. Some of these are simply for debug purposes. I don't think any of these are included in the autodoc.

A minor comment re the pdf document... countries boundaries are missing on the map (section 4.1 P36)

@LouisAK The PDF generated today does include country boundaries. Not sure that has changed.

@APSIMInitiative/reference-panel I have also constructed a sensibility test for peanut for Northland in NZ using weather data from Val and soil data from APSoil. I've used the sowing date, population and preferred soil types obtained from articles found on the web. Yield seems to match potential yeilds from same articles. I would still suggest some caution in use for new environments. However, the sensibility test seems plausible for now.