APSL / react-native-item-cell

React Native default iOS item cell

MIT License

72 stars 15 forks source link

Component type of icon prop type support #20

Open ngxiaoyi opened 7 years ago

ngxiaoyi commented 7 years ago

Hi there,

If this component plugin depends on the font - FontAwesome which comes from the repository : react-native-vector-icons. Why not support component type for the 'icon' prop directly?

eg:

import ItemCell from 'react-native-item-cell'; import Icon from 'react-native-vector-icons/FontAwesome'; <ItemCell icon={<Icon name="rocket"/>} > Item </ItemCell>

just a feature wanted

ngxiaoyi commented 7 years ago

Filed a PR: https://github.com/APSL/react-native-item-cell/pull/21

Please have a review and fell free to handle it. Thanks