Closed AndreeWille closed 1 year ago
Hi @AndreeWille .
It seems it works fine! Thanks a lot.
Oh wow! That was quick! Thank you very much!
I've got a problem with my "npmjs" credentials and I cannot deploy the new version, yet. It will be solved on Monday.
@francescarpi i just noticed the change is not published yet. Let me know when i can help you with anything.
Hi @AndreeWille . Sorry, we had problems with our npm's account. It's solved. I just publish the new version 1.5.25. Thanks
This replaces optimist with minimist because optimist is no longer maintained and has a security issue related to an older version of minimist. See #133
francescarpi It looks like the tests doesn't cover the import and export scripts so i was not able to test it. Also i am not familiar with redux-i18n so i didn't add new tests. On the other hand i checked with a node script that the behaviour of the two libraries are the same.
then i ran
node index.js --foo bar hello world
output:
The only difference is see is $0 property in the optimist version which is missing in minimist. I am not sure about if this is an issue or if this information is not needed for redux-i18n