search

APY / APYBreadcrumbTrailBundle

Generate a dynamic Twig breadcrumbs trail via Annotations, PHP Attributes or PHP methods.
80 stars 31 forks source link

% sig in deprecation message breaks synfony on php8 #57

Closed Richard87 closed 3 years ago

Richard87 commented 3 years ago

Master branch is broken on php8 / symfony, the % sign is not supported in the deprecation message: https://github.com/symfony/symfony/issues/40630.

The problem is in services.xml, i would submit a PR, but im out of the office 😅

rvanlaak commented 3 years ago

I just merged PR #58 to test on PHP8 and Symfony latest. No code changes were needed to get that PR green, just changes to the CI.yaml file to include these versions. As you can see, tests on all latest versions are green.

@Richard87 Could it be that the latest release is broken on the latest Symfony, instead of master as you're mentioning? Can you verify that by requiring dev-master in your project and run bin/console cache:warmup again? If that solves your problem, I will tag a new release.

And, can you share a sample of the code where you are using this bundle?

Richard87 commented 3 years ago

Thanks, it works perfect here to after running composer update in php8 environment... maybe I messed it up by using composer install in php7 and running it in php8 or something....

Thanks for checking it out!