search

APY / APYBreadcrumbTrailBundle

Generate a dynamic Twig breadcrumbs trail via Annotations, PHP Attributes or PHP methods.
80 stars 31 forks source link

Deprecation notices (symfony 5.2.6 / deprecation-contracts 2.4.0) #60

Closed knallcharge closed 3 years ago

knallcharge commented 3 years ago

After updating the symfony deprecation-contracts to 2.4 I get these notices: Since symfony/dependency-injection 5.1: Not setting the attribute "package" of the node "deprecated" in "(...)\vendor\apy\breadcrumbtrail-bundle\src\DependencyInjection/../Resources/config\services.xml" is deprecated. and Since symfony/dependency-injection 5.1: Not setting the attribute "version" of the node "deprecated" in "(...)\vendor\apy\breadcrumbtrail-bundle\src\DependencyInjection/../Resources/config\services.xml" is deprecated. It seems that services.xml is missing the mentioned tags "package" and "version".

knallcharge commented 3 years ago

It seems that with commit 3a488af these tags were removed, is there a reason for that change or could the commit just be reversed to fix this issue?

rvanlaak commented 3 years ago

These are not BC compatible with lower Symfony versions we still can easily support with this bundle. Currently there are no plans on bumping the requirements, until Symfony 6 appears where these BC warnings are removed and an error would get thrown.