search

APY / APYDataGridBundle

Symfony Datagrid Bundle
MIT License
493 stars 343 forks source link

Update for Symfony 4 #990

Closed parasetam0l closed 6 years ago

parasetam0l commented 6 years ago

Hello, I started to use APYDataGridBundle on my new Symfony 4 project. I forked project and solved some problems. Now bundle is not giving any installation or deprecation error. I can not get work "symfony/symfony": "~2.8|~3.0|^4.0" line in composer.json. I think it can be replaced by "symfony/framework-bundle" etc. But I removed that line temporary for my project. Still working on it.

PS: Do not use AbstractController class while extending your Controller. Use Controller class. Otherwise you will get '"grid" service not found' error.

Thank you!

dfridrich commented 6 years ago

@Abhoryo, this bundle should be compatible with SF4 as soon as possible.

bartosz-malec commented 6 years ago

Hi guys, any changes? When the bundle will be available for SF4?

DonCallisto commented 6 years ago

This bundle should be already symfony 4 compliant without any changes, AFAIK. It's not configured with autowire/autoregistration and can't not be fetched from FLEX, but I'm pretty sure you can upgrade safely to symfony4.

If instead you have only components from sf4 it's good - and we have #1009 - to split what the bundle depends on. I currently can't work on it but as soon as #1009 (or this) will be fine, I do the merge.

romainguerrero commented 6 years ago

I don't think you can totally remove the symfony/symfony dependency but for this problem the PR #1011 should resolved it. For the other parts I am also interested in this PR to be able to use a public grid service in my Symfony 4 project (for the moment I use a public alias...) but I'm not sure that setting "public" as default visibility for services is a good idea in reference to the Symfony recommandations. Maybe you could explicitly indicate as public only services which are supposed to be used by developers ?