nus-pe-bot
commented
2 years ago Team's Response
Hi, thank you for your advice. However, only the first letter will be taken. It is highlighted in UG (graph1) as well as prompt information for the game(graph1).
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Guessing letter game takes in multiple letters when it should ideally take in only one
Perhaps it would be better to indicate this as an invalid input because hangman technically only should accept one letter?
[original: nus-cs2113-AY2122S1/pe-interim#2445] [original labels: type.FeatureFlaw severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Hi, thank you for your advice. It is shown in the game message. Only accept the first letter.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Even though it is mentioned in the prompt that users are only allowed to use 1 letter, there should at least be some sort of exception handling to catch when users try to type an invalid command as opposed to allowing me to continue playing the game and treating my invalid input 'a1' as a valid attempt and deduct my remaining tries. In addition, 'a1' is not a letter but rather an alphanumerical, hence it shows a lack of sanitisation of the user's input to abide by the stipulated game guidelines decided by the team.
As a user, who may not know what alphabets are (which is very unlikely), may think that 'a1' is a valid alphabet and for future iterations of the game, continue inputting concatenated alphabet with numerals. I see this as a possibility as your target users are kids who are pretty young and may not have the proper experience to discern what alphabets are.
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
When playing the hangman game, I was able to type 'a1' as an accepted input by the program even though the previous erroneous inputs I tried required me to type only alphabets.
There is a lack of sanitisation for the hangman input, which went against the pre-defined rules of only being able to specify alphabets, which will waste the user's remaining number of chances to guess the letter.