APZH / pe

0 stars 0 forks source link

Does not save user creation data when closing the command prompt or exiting the program via Ctrl-C after creation on the program interface. #8

Open APZH opened 2 years ago

APZH commented 2 years ago

image.png

As shown in the image above, I used the 'newgame' command to create a new user called Charlier and the relevant user-id is circled in red in the image.

Then I tried to exit the program by using Ctrl-C, and re-enter the program again.

When I tried to use the 'continue' command to retrieve the previously created profile for 'Charlie', it produce an error that that Charlie's local data file could not be found, and I had to recreate the profile again.

soc-pe-bot commented 2 years ago

Team's Response

Hi, Thank you for your advice. However, I have to reject it because the app does not allow storage when you force quit the app. You should use exit in the main menu. This is also mentioned in UG.

It is also practical in real computer games as you need to click the exit button on the main page. pe-3.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: From a user's perspective, when I create the profile and the command prompt tells me that they have issued me my ID and asks me to remember it for future games, I would assume that my user portfolio is already saved in the computer. Force quitting the app by closing the terminal or ctrl-C is to test when the profile is created, which was found to not be when the command prompt informs the user of his/her user id to remember, giving a false impression to the user that I have a local account created already. Users should not have to exit in the main menu to save the profile as they may be lazy to exit the application that way and choose to close the command prompt or ctrl-c directly.

If I may suggest, the saving of user profile should be done at the point when the user is informed of his user id and not when the user exits the application properly via the exit command.


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: One of the application's core functionality is the ability to save a user's portfolio locally. Hence I feel that it is important to fix the issue of user profile creation, which was the reason I placed the severity as high. In hindsight, I think that the severity could be 'Medium' as it does not break the usage of the application but rather the uncertainty of the user's data being saved.