search

APZelos / blamer.nvim

A git blame plugin for neovim inspired by VS Code's GitLens plugin
MIT License
733 stars 35 forks source link

Support Vim and Windows #13

Closed tamago324 closed 4 years ago

tamago324 commented 4 years ago

It looked like a great plugin, so I wanted to use it with Vim. Implemented using the popup feature of Vim.

We also added Windows support.

Thank you!

Refer #8

tamago324 commented 4 years ago

Thank you review 😂 Fixed.

tamago324 commented 4 years ago

Thank you for merging!

junkblocker commented 4 years ago

Does this really work? In gvim (8.1.2234) I get

Error detected while processing function <lambda>9[1]..blamer#Show[23]..blamer#CreatePopup:
line   16:
E475: Invalid argument: blamer_popup_marker
tamago324 commented 4 years ago

@junkblocker How to reproduce it?

junkblocker commented 4 years ago

This is on macOS latest.

  1. Remove all .vimrc , .vim or move them aside etc.
  2. cd && git clone https://github.com/APZelos/blamer.nvim.git .vim
  3. cd .vim
  4. gvim
  5. :e README.md
  6. :BlamerToggle
soohyun0131-lee commented 4 years ago

@junkblocker Hi, did you solve the problem? I met the same error too. (in Ubuntu 20.04)

Error detected while processing function <lambda>9[1]..blamer#Show[23]..blamer#CreatePopup:
line   16:
E475: Invalid argument: blamer_popup_marker
junkblocker commented 4 years ago

@mozzi0131 - I have been running VimR (nvim) instead of MacVim for a while now, so, not sure. Just tried with MacVim and :BlamerShow just shows the first line I am on when I switch it on but doesn't move to other lines as I move the cursor...so busted in different ways.

tamago324 commented 4 years ago

I also tried to get it to work on Neovim on Ubuntu recently, but it didn't work, so when I have time, I'll take a look.

soohyun0131-lee commented 4 years ago

@junkblocker @tamago324 Thanks for sharing! It seems like it is not working on vim, Ubuntu 20.04.