search

APickledWalrus / skript-placeholders

Placeholder integration for Skript.
GNU General Public License v3.0
28 stars 8 forks source link

EvtPlaceholderRequest NullPointerException #27

Closed FinnChildress closed 3 years ago

FinnChildress commented 3 years ago

Description

Rarely when a player leaves my server it causes an error in Skript and the server enters a crashed state.

Steps to Reproduce

  1. Install Skript
  2. Install skript-placeholders
  3. Have about 2000 players leave a server

Expected Behavior

No errors

Errors / Screenshots

https://gist.github.com/FinnChildress/95db2e3ade93fd4ca30927f4272a8554

Server Information

Additional Context

This has happened many times. I am only making an issue about it here so that it can stop.

FinnChildress commented 3 years ago

Not sure if it would be possible, but could you just remove the "return null" on line 50 of EvtPlaceholderRequest.java? I am not sure that you need the check to see if they are online at all, so you may be able to just do the cast without a check.

APickledWalrus commented 3 years ago

Hello! Thank you for this report. Please try the latest nightly build which you can download at https://github.com/APickledWalrus/skript-placeholders/suites/3240787961/artifacts/75215981

Let me know if this solves your issue and/or if you encounter any additional errors. If all is good, I will release a new version with this fix :)

FinnChildress commented 3 years ago

Great thank you! I will try that build and let you know if the issue happens again. Since it usually only happens about once a week or so, it may be multiple weeks until I know for sure that this issue has been fixed.

If I don't report anything in the next few days, please assume that it is fine and close the report. I will re-open this issue or submit a new one if the bug happens again.

APickledWalrus commented 3 years ago

Marking this as complete as it has been a few weeks :)

Edit: fixed in new release