APickledWalrus / skript-placeholders

Placeholder integration for Skript.
GNU General Public License v3.0
28 stars 8 forks source link

Latest PAPI update broke this addon (?) #37

Closed TobyMinceraft closed 1 year ago

TobyMinceraft commented 1 year ago

Description

Using the latest PAPI release (v2.11.2) with also the latest version of this addon and Skript, I am getting this error when I try to register a placeholder java.lang.IllegalStateException: ExpansionRegisterEvent may only be triggered synchronously.

Steps to Reproduce

  1. Create a script file as normal to make a placeholder
  2. Update PAPI to 2.11.2, skript-placeholders to 1.5.2, and Skript to 2.6.3
  3. Run the code to make the placeholder

Expected Behavior

Well... this should be self-explanatory: I expected the placeholder to register itself

Errors / Screenshots

Full stack-trace of the error here: https://pastebin.com/jEcaBqAq

Server Information

Additional Context

n/a

EDIT

It seems like this error occurs with versions lower as well. I have tried as low as 2.10.10 and same results

TobyMinceraft commented 1 year ago

Turns out, the issue was either this addon or PAPI not liking the way Skript handles asynchronous tasks. If anyone else experiences this, make sure to set script loader thread size in the Skript config to 0.