search

APickledWalrus / skript-placeholders

Placeholder integration for Skript.
MIT License
29 stars 9 forks source link

Make the MVdW Placeholder Request event have more logic #5

Closed Mwexim closed 4 years ago

Mwexim commented 4 years ago
  1. It can now be fired with 'on', the keyword every event has as optional.
  2. The placeholder at 'placeholderapi placeholder' is now optional to match the syntax of the PAPI event better. Small QoL change, not really necessary.
APickledWalrus commented 4 years ago

The on part is auto applied by skript, so that part is not necessary. Are you having errors when trying to use it?

Mwexim commented 4 years ago

I don’t have errors. Maybe you should apply the [on] at the wiki. Other than my second points this PR can be closed.

APickledWalrus commented 4 years ago

Will do :)

I will manually apply the change suggested in your second point. For now, I’m going to keep this pull request open so I don’t forget haha

EDIT: Changes will be applied in the next update :)