APickledWalrus / skript-placeholders

Placeholder integration for Skript.
GNU General Public License v3.0
27 stars 7 forks source link

Reloading skript breaks other placeholders #59

Open RealSypher opened 3 weeks ago

RealSypher commented 3 weeks ago

Description

Whenever I reload a skript, another skript's placeholders break.

Steps to Reproduce

Reload a skript with a placeholder, then reload another skript with a placeholder.

Expected Behavior

All placeholders work

Errors / Screenshots

https://youtu.be/xKPziHIg3Sw

image

Server Information

Additional Context

APickledWalrus commented 3 weeks ago

Are you registering a placeholder with the same prefix in multiple scripts?

RealSypher commented 3 weeks ago

Yes. However, I did this a while ago in 1.18 and it worked fine.

RealSypher commented 3 weeks ago

To add, I am reusing the exact same skripts and after reviewing the documentation they should still work fine....

APickledWalrus commented 3 weeks ago

Ah yeah I can see why it stopped working. I believe I fixed this issue already in the upcoming 1.7.0 release. I'll try to see if I can get that out this week.

RealSypher commented 3 weeks ago

Alright, thanks! Looking forward to it.

APickledWalrus commented 3 weeks ago

I'll keep this open for now until I confirm the issue is resolved and until 1.7.0 is released. 🙂

RealSypher commented 2 weeks ago

Is there an ETA for the update?

APickledWalrus commented 2 weeks ago

Sorry, I'm aiming to get it out by the end of the week (Friday/Saturday)

RealSypher commented 2 weeks ago

No worries, take your time!