search

APickledWalrus / skript-placeholders

Placeholder integration for Skript.
GNU General Public License v3.0
28 stars 8 forks source link

1.21 compatibility #60

Open Readopted opened 1 month ago

Readopted commented 1 month ago

Description

Please add 1.21 compatibility.

APickledWalrus commented 1 month ago

Are you having an issue with the addon on 1.21?

Readopted commented 1 month ago

Yes, although im not really sure if 1.21 is the problem.

When using your example in the wiki:

command /hello:
  trigger:
    set {_value} to the value of the placeholder "skriptplaceholders_name" for the player
    send "Hello, your name is %{_value}%" to the player

I get this error: 

[15:52:35 INFO]: [Skript] Reloading customplaceholders.sk...
[15:52:35 INFO]: Line 3: (customplaceholders.sk)
[15:52:35 INFO]:     Can't understand this expression: 'the value of the placeholder "skriptplaceholders_name" for the player'
[15:52:35 INFO]:     Line: set {_value} to the value of the placeholder "skriptplaceholders_name" for the player
[15:52:35 INFO]:  
[15:52:35 INFO]: [Skript] Encountered 1 error while reloading customplaceholders.sk! (33ms)

And get the following when entering the command:

image

APickledWalrus commented 1 month ago

Ah that might be the wiki page for the upcoming release. Try referencing this page: https://github.com/APickledWalrus/skript-placeholders/wiki/Old-Documentation-(for-versions-1.6.0-and-older)#getting-the-value-of-placeholders