Closed ChristinaLast closed 1 year ago
@jit-1 lmk if you were able to setup pre-commit locally (as this isnt something the repo enforces but will be helpful to maintain code quality).
- Unable to find the package installation of pre-commit in the poetry setup
- Issue with docker '''sudo usermod -aG docker $USER'''
usermod: group 'docker' does not exist Based on closer inspection, I could not find at which step docker is being installed. Unable to use docker -v or anything to check the docker version
Maybe lets fix the docker stuff in another Pull request because I think you worked on that so Im not sure what you did there. In fact, I think there is a currently stale branch that has got some docker fixing being worked on (https://github.com/AQ-AI/openaq-engine/pull/12)
I have pushed the pre-commit
addition to poetry packaging. please re-review.
Description
This PR fixes a few of the issues highlighted with Lili this morning.
setup.cfg
to structure the style of our code inyml
Fixes #32
Type of change
Please delete options that are not relevant.
How has this been tested?
To check pre-commit works: Follow instructions line 161-168 in
README.md
To run tests for coverage check
Please describe the tests that you ran to verify your changes.
Checklist: