AR-js-org / AR.js-threejs

An experimental Typescript module for AR.js
MIT License
30 stars 2 forks source link

Implementing remaining classes #10

Closed kalwalt closed 3 months ago

kalwalt commented 1 year ago

Implementing remaining ARjs and THREEx classes

I planned to add all the remining classes to the project but i wasn't able to transform the markers-area code in a tyescript version without any bug. But at the end i added most of them, see here the list:

ARjs namespace

About markers-area and multimarkers learner and all related stuff: I can think to add in another stage of the development, i think it's more important create an aframe package to try to import the ar.js-threejs package.

kalwalt commented 1 year ago

With the latest commit thearjs-session.html example works partially. It detect and track the hiro marker only with the artoolkit mode enabled. Instead it should works for the other area types area-artoolkit and best. I got with these lasts this error message:

Asserzione non riuscita:console.assert
defaultMarker @ ar.js:1
(anonimo) @ arjs-session.html:72
(anonimo) @ arjs-session.html:190

and after:

ar.js:1  Uncaught TypeError: Cannot read properties of undefined (reading 'forEach')
    at new J (ar.js:1:1607858)
    at arjs-session.html:96:32
    at arjs-session.html:190:15

I think if i solve this issue the code will be almost ready to be merged.

kalwalt commented 3 months ago

I think the issue came from the markers-area maybe i can try to remove this code?

kalwalt commented 3 months ago

With the last two commits i don't receive the errors mentioned in the previous comment, for sure it detect the hiro marker with the artoolkit mode i need to confirm for the other options too. But i think this could be a temporary solution.

kalwalt commented 3 months ago

For future reference, see my comment about multimarkers support. I'm going to remove the markers-area code.