AR-js-org / AR.js-threejs

An experimental Typescript module for AR.js
MIT License
30 stars 2 forks source link

Typescript errors in ArMarkerHelper and ArToolkitSource.ts #14

Closed kalwalt closed 3 months ago

kalwalt commented 3 months ago

I get errors like this in a testing repository: For ArMarkerHelper.ts:

 ERROR in C:\path\to\node_modules\@ar-js-org\ar.js-threejs\src\ArMarkerHelper.ts(22,16)
      TS2339: Property 'width' does not exist on type 'Entity<ObjectMap<Component<any, System<any>>>>'.

this is the code: https://github.com/AR-js-org/AR.js-threejs/blob/df206b183ef61f8bf91083f9fdb6488423409876/src/ArMarkerHelper.ts#L21-L23

For ArToolkitSource.ts:

ERROR in C:\path\to\node_modules\@ar-js-org\ar.js-threejs\src\ArToolkitSource.ts(257,9)
      TS2740: Type 'Entity<ObjectMap<Component<any, System<any>>>>' is missing the following properties from type 'HTMLImageElement': align, alt, border, complete, and 23 more. 
kalwalt commented 3 months ago

With the last commit the errors mentioned above are disappeared, this issue can be closed.