search

AR-js-org / AR.js-threejs

An experimental Typescript module for AR.js
MIT License
30 stars 2 forks source link

ArMarkerControls id output NaN instead of a number #5

Open kalwalt opened 1 year ago

kalwalt commented 1 year ago

Note: ArMarkerControls is a dervied class from ArBaseControls This happens because i implemented the code in this way https://github.com/AR-js-org/AR.js-threejs/blob/9c8e08bac13f921d513c91451a32fcd006a32715/src/ArBaseControls.ts#L3-L14 original AR.js code here: 

const ArBaseControls = function (object3d) {
  this.id = ArBaseControls.id++;

  this.object3d = object3d;
  this.object3d.matrixAutoUpdate = false;
  this.object3d.visible = false;

  // Events to honor
  // this.dispatchEvent({ type: 'becameVisible' })
  // this.dispatchEvent({ type: 'markerVisible' })  // replace markerFound
  // this.dispatchEvent({ type: 'becameUnVisible' })
};

ArBaseControls.id = 0;

https://github.com/AR-js-org/AR.js/blob/be7c9083df5a651c2ab978ddd7c1a33409c4d40b/three.js/src/threex/threex-arbasecontrols.js#L3-L16 I think this is a bad idea. The _id(should be re-named id) should simply be incremented and not added by the static id property. I will fix this.