AR-js-org / AR.js

Image tracking, Location Based AR, Marker tracking. All on the Web.
MIT License
5.32k stars 911 forks source link

Cable centered position of content in NFT inside AR.js core #4

Open nicolocarpignoli opened 4 years ago

nicolocarpignoli commented 4 years ago

Content is placed at 0,0 position. Can be useful if it's present at the center of the marker. We have to understand if this has to be fixed on jsartoolkit5 side (better) or on AR.js core.

nicolocarpignoli commented 4 years ago

In my opinion, this should be done inside jsartoolkit5, possibly as an option. Anyway, not to be implemented directly on AR.js

JamesBotterill commented 4 years ago

For video setting the position to the centre of the marker is really useful.

kalwalt commented 4 years ago

For video setting the position to the centre of the marker is really useful.

@JamesBotterill I think that will be useful also for placing other model types. I have a branch and there is also a PR https://github.com/kalwalt/jsartoolkit5/pull/42 on my jsartoolkit5 repository where we are trying to achieve this. I think after the v 3.0.0 release we'll come back on this.

kalwalt commented 4 years ago

There are some news on this side: with the latest commit https://github.com/kalwalt/jsartoolkit5/pull/42/commits/86a19807000d9452ff537f8aa97775629c60d418 in my PR https://github.com/kalwalt/jsartoolkit5/pull/42 it's easier to reposition the model in the center of the marker. Tests are welcome!

93Dennis commented 4 years ago

Any news on this one, yet, @kalwalt? Unfortunately, it's not really usable for production in this condition. Thank you very much for your work! :)

kalwalt commented 4 years ago

@93Dennis i have no any news, sincerely i have no time to dedicate. My actual job do not let me so much free time ..

patrickoshaughnessey commented 4 years ago

I have seen this same behavior using the NFT three.js sample. I added a red sphere to 0,0,0 and it shows up in different places depending upon the resolution and orientation of the phone (landscape vs. portrait). Is this really a duplicate of #109?This one seems to be more about making 0,0,0 be the center of the marker, which I agree would be convenient. However, #109 is about making the 0,0,0 coordinate be consistent, even if it is the lower left (which it is now). I suppose one wouldn't be possible without the other, but consistency of placement seems more important than where the origin is placed.

Attached some images I took on my Galaxy Tab S6 + Chrome + Android 10 at 640x480 and 480x640, in both portrait and landscape.

480x640 Landscape GalaxyTabS6 Chrome83 0 4103 106 Android10 480x640 Portrait GalaxyTabS6 Chrome83 0 4103 106 Android10 640x480 Portrait GalaxyTabS6 Chrome83 0 4103 106 Android10 640x480 Landscape GalaxyTabS6 Chrome83 0 4103 106 Android10
Dryra commented 3 years ago

Hello, Thank you for the amazing work on AR,js!

Are there any updates regarding this issue? We would like to use AR.js as our WebAR solution, but this issue is making it hard to release to production.

Best.

PedroNan commented 3 years ago

I have the same problem and I partially solved it by adjusting the position and rotation of the video, is there a solution currently? by the way, I also have a bigger problem, the NFT image recognition system works with the trex image in the example, but when I change this image to a custom one it doesn't work and the application gets stuck on the message of "loading, for please wait "and he never moves from here. Any ideas how to fix it?

RBOSAMIYA9 commented 2 years ago

@PedroNan I was having same problem as you

problem

stuck at loading screen

why its happning?

It happening because of wrong path/url in src of nft tag or wrong path/url in your 3d file/img/video

or

you may have missed / forgot to get your .iset and .ifset and host them

or

you may have forget to add arjs proxy (for cors related issue).

Djek177 commented 1 year ago

Hello hello,

Any update on this ?

I'm trying to play video with a NFT image, all working great but the positioning of the video. I tried to give dev branch a shot but I get this : Error in loading marker on Worker TypeError: Q.getNFTData is not a function

Thanks !