search

AR-js-org / AR.js

Image tracking, Location Based AR, Marker tracking. All on the Web.
MIT License
5.3k stars 909 forks source link

Update index.html #518

Closed sizxle closed 10 months ago

sizxle commented 1 year ago

using the new GPS components

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?

Can it be referenced to an Issue? If so what is the issue # ?

How can we test it?

Summary

Does this PR introduce a breaking change?

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser

Other information

nickw1 commented 1 year ago

Hi @sizxle, thanks for your PR. Please note, however, that the new-location-based directory contains examples designed for the new-location-based components (gps-new-camera and gps-new-entity-place). The location-based directory is intended for the older components, in case people have problems with the new components.

So I think it's best that the example that the PR relates to is not changed. Is that OK?

sizxle commented 1 year ago

Sounds good, @nickw1 . I am interested in using AR.js for AR development, but as a beginner, I struggle to find answers to some of my questions, especially with location-based AR. Is there a way for me to contact you so that you can help me figure out some things?

nickw1 commented 1 year ago

@sizxle yes, I can do, but I don't want to give out my email address in public here. Best thing to do is if I create a dummy private repo on GitHub, containing it, and invite you to it.

Is it ok if I close this PR, in the light of my comments above?