Open juanRabaa opened 10 months ago
@juanRabaa thanks, will give this a go. @kalwalt do you also want to review this?
(sorry for late reply by the way, it's been a while since I've had the chance to look at AR.js).
@juanRabaa thanks, will give this a go. @kalwalt do you also want to review this?
(sorry for late reply by the way, it's been a while since I've had the chance to look at AR.js).
I hope to have some spare time after the 7 january, it was on my radar but i haven't had the time...
⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️
What kind of change does this PR introduce?
Can it be referenced to an Issue? If so what is the issue # ?
504
How can we test it? Run build and import
three.js/build/ar-threex-location-only.js
. I made a package of this fork to test this out and seems to work fine.Summary
threex-location-only
output mode tomodule
to fix multiple instances of threejs error when importing boththree
and thethreex-location-only
build
andbuild:dev
scripts to usewebpack
instead of./node_modules/.bin/webpack
. It was producing an error in my machine and I guess others. It should work in every machine with justwebpack
.Does this PR introduce a breaking change?
This will limit the
threex-location-only
build to be used only as a module. I think, if needed, more than one build can be made, one with the previous configuration UMD . I don't expect this to be merged as is, there probably is a better solution.Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
OS: Windows 10 Browser: Chrome V.116.0.5845.141