search

AR-js-org / AR.js

Image tracking, Location Based AR, Marker tracking. All on the Web.
MIT License
5.3k stars 909 forks source link

fix: changed "Twitter" to "𝕏 (Twitter)" in README.md #581

Closed BandhiyaHardik closed 7 months ago

BandhiyaHardik commented 8 months ago

changed Twitter's old name to new one 𝕏

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce? changed "Twitter" to "𝕏 (Twitter)" in README.md Can it be referenced to an Issue? If so what is the issue # ? https://github.com/AR-js-org/AR.js/issues/580 How can we test it?

Summary

Does this PR introduce a breaking change?

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser

Other information

kalwalt commented 8 months ago

Hi @BandhiyaHardik thank you for you PR. Generally we require pull requests pointing to the dev branch, but because it will cause any issue maybe we can merge as it is, what do you think @nickw1 ?

BandhiyaHardik commented 8 months ago

Hi @BandhiyaHardik thank you for you PR. Generally we require pull requests pointing to the dev branch, but because it will cause any issue maybe we can merge as it is, what do you think @nickw1 ?

@kalwalt From next time i will keep this in mind and make sure i open my PR in dev branch in this repository.