AR-js-org / AR.js

Image tracking, Location Based AR, Marker tracking. All on the Web.
MIT License
5.45k stars 926 forks source link

Issue with branch protection rule #616

Open kalwalt opened 5 days ago

kalwalt commented 5 days ago

Do you want to request a feature or report a bug? This is a bug occurred when we merged this PR #610 see comment this is the message in the action github log:

Run EndBug/add-and-commit@v9
Running in /home/runner/work/AR.js/AR.js
Add input parsed as string array, running 2 git add commands.
> Using 'github-actions <41898282+github-actions[bot]@users.noreply.github.com>' as author.
> Using "new build files from action" as commit message.
Internal logs
Outputs
Error: Error: To https://github.com/AR-js-org/AR.js
!   refs/heads/master:refs/heads/master [remote rejected] (protected branch hook declined)
Done
Pushing to https://github.com/AR-js-org/AR.js
POST git-receive-pack (3936 bytes)
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: 
remote: - Changes must be made through a pull request.        
error: failed to push some refs to 'https://github.com/AR-js-org/AR.js'

What is the current behavior? The rule prevent to make a commit directly in the master branch, a PR is required with one review of the maintainers. But when the EndBug/add-and-commit@v9 want to commit the build files, it fails because the branch rule prevent this, it should instead create a PR pointing to the master branch.

If the current behavior is a bug, please provide the steps to reproduce. as said see #610.

Please mention other relevant information such as the browser version, Operating System and Device Name No needs of this infos. What is the expected behavior? The github action should be successful. If this is a feature request, what is motivation or use case for changing the behavior?

kalwalt commented 5 days ago

@nickw1 I didn't find a solutuion yet maybe i will ask support to the EndBug/add-and-commit@v9 devs.

kalwalt commented 5 days ago

This issue https://github.com/EndBug/add-and-commit/issues/485 can be the solution