AR-js-org / AR.js

Image tracking, Location Based AR, Marker tracking. All on the Web.
MIT License
5.46k stars 928 forks source link

Test examples for Aframe, three.js, all features (GPS + marker + NFT) #9

Open nicolocarpignoli opened 4 years ago

nicolocarpignoli commented 4 years ago

Because the file structure is changed, all the examples need to be tested (Aframe and Three.js). We will report here if we found some bug or issue. Note: test the master branch ! Thank you!

kalwalt commented 4 years ago

Tested the markers examples on desktop:

Three.js examples:

Aframe examples:

Aframe examples are not affected by the fullscreen issue as for the Three.js's because the canvas is not boxed.

nicolocarpignoli commented 4 years ago

About three.js issue, I encountered this before, working on first NFT cases on AR.js. It should be fixed with latest modify with setTimeout. You can pull and try 'basic.html' example. Let me know. If it works, we can replicate it for every three.js example - anyway, it's just a matter of 'onResize' not being called at the right time.

kalwalt commented 4 years ago

i saw your changes i will see tomorrow, Thanks!