search

ARC-Lab-UF / testbench-runner

Interactive testbench runner via Modelsim. Integrates with Canvas assignments.
2 stars 1 forks source link

Names with hyphens and apostrophes are skipped #26

Open benjamin051000 opened 1 year ago

benjamin051000 commented 1 year ago

This was definitely an issue before, but seems to have popped up again.

Names with the pattern (real names redacted) <Firstname> <Lastnameone>-<Lastnametwo>

Are not extracting properly. They should have unzipped directories created for them in Submissions/ and their names should be shown in the "Students to grade" list.

benjamin051000 commented 1 year ago

A solution has been identified:

Replacing the "-" in the last name with a space " " resolves the issue. This worked when utilizing the --section flag. The names were edited in the all_students.csv file.

Note: In the CSV, the entry is <Lastnameone>-<Lastnametwo>, <Firstname>. Replacing the - with a space resolved the problem.

benjamin051000 commented 1 year ago

FYI, when viewing the .csv raw, the first entry allows for a comma because it is wrapped in quotes. This is how it looks:

"<Lastnameone>-<Lastnametwo>, <Firstname>", ufid, blah, blah, blah

the comma within the first column is ignored since the quotes "escape" it.

jalvarez1492 commented 1 year ago

This issue also happens with apostrophe last names, I will try just editing the all_students.csv file to replace it with a space.

benjamin051000 commented 1 year ago

It may be worth utilizing a third-party package for this, such as https://github.com/derek73/python-nameparser

Before we do that, however, I'd want to test it and see how well it performs, especially for people with more than two names, names with - and ', etc. I could test on previous years' submission datasets... I just wish canvas didn't do the stupid name mangling!

benjamin051000 commented 1 year ago

Thanks @jalvarez1492 , I think the above package may be a good potential solution to this.