search

ARC-OPT / wbc

C++ library for optimization-based control of redundant robots
BSD 3-Clause "New" or "Revised" License
33 stars 13 forks source link

JOSS: Dependencies #99

Closed mhubii closed 2 months ago

mhubii commented 3 months ago

Please always advise if incorrect.

In the installation, I can find plenty cloning. Would it make sense to add theses as git submodules in a third_party folder?

I am talking about these:

https://github.com/ARC-OPT/wbc/blob/154389f28d5a64c18eb89cd7e1a5281a4dbd55ce/scripts/full_install.sh#L78

Refers https://github.com/openjournals/joss-reviews/issues/6696

dmronga commented 2 months ago

Thank you for remark. So, I checked this option and in fact it makes the install a bit cleaner when using the library standalone. However, in frameworks like ROS and Rock (https://www.rock-robotics.org/) some or all of the third party libraries are installed using package management tools. Here, I would have to add if ... else statements in CMakeLists.txt to distinguish between the different installs. Thus, I would like to keep it the way it is, although it is not ideal.