search

ARC-OPT / wbc_ros

ROS/ROS2 wrappers for the Whole-Body Control library
https://arc-opt.github.io/Documentation/
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

JOSS: Dependencies #10

Closed mhubii closed 2 months ago

mhubii commented 2 months ago

package.xml / CMakeLists.txt dependency mismatch:

package.xml:

  <depend>geometry_msgs</depend>
  <depend>controller_interface</depend>
  <depend>controller_manager</depend>
  <depend>xacro</depend>
  <depend>rclcpp_lifecycle</depend>
  <depend>sensor_msgs</depend>
  <depend>trajectory_msgs</depend>
  <depend>realtime_tools</depend>
  <depend>joint_state_broadcaster</depend>
  <depend>std_msgs</depend>
  <depend>generate_parameter_library</depend>

CMake:

  rclcpp
  realtime_tools
  std_msgs
  geometry_msgs
  trajectory_msgs
  wbc_msgs
  sensor_msgs
  pluginlib
  rclcpp_lifecycle
  controller_interface
  hardware_interface
  generate_parameter_library

Example in readme https://github.com/ARC-OPT/wbc_ros#examples should not need to highlight manual installation if package.xml was configured correctly (usually handled through rosdep) (optional)

Refers to https://github.com/openjournals/joss-reviews/issues/6696

dmronga commented 2 months ago

@mhubii I fixed the dependencies. However, I cannot add wbc_msgs to package.xml as this package is not the ros index. Therefore, the slightly complicated install instructions here. If you know a way around this, please advice.

mhubii commented 2 months ago

hi @dmronga , yes, you can add --ignore-src or -i to rosdep, you can read the doc through rosdep --help