search

ARCANEDEV / SEO-Helper

:mag: SEO Helper is a package that provides tools and helpers for SEO (Search Engine Optimization).
MIT License
327 stars 49 forks source link

Convenience method to setup images in the controller. #26

Closed kikoseijo closed 7 years ago

kikoseijo commented 7 years ago

Now you can do something like, : and update the image on the cards and open graph.

$this->seo()
          ->setTitle(trans('conectores.'.$conector_id.'.seo_title'))
          ->setImage(asset('img/conectores-aplicaciones-moviles/modulo-'.$conector_id.'.png'))
          ->setDescription(trans('conectores.'.$conector_id.'.seo_desc'));
arcanedev-maroc commented 7 years ago

Hi @kikoseijo, thanks for your pull request.

There are multiple changes that breaks the code style i'm using and also missing tests + unnecessary files added (.DS_Store).

I'm going to add this feature today with tests.

But I really appreciate your spending time with this PR 👍

arcanedev-maroc commented 7 years ago

Done: #27

arcanedev-maroc commented 7 years ago

@kikoseijo try to update the seo-helper to 1.3.1 and see if it works for you.

kikoseijo commented 7 years ago

I love it, I really do, you got nice peace of work here. I did at 6AM after a working marathon,

Point to me what else needs done and ill do, I don’t mind, Illl like to help.

Thanks for your reply.

On 27 Feb 2017, at 19:12, ARCANEDEV notifications@github.com wrote:

Hi @kikoseijo https://github.com/kikoseijo, thanks for your pull request.

There are multiple changes that breaks the code style i'm using and also missing tests + unnecessary files added (.DS_Store).

I'm going to add this feature today with tests.

But I really appreciate your spending time with this PR 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ARCANEDEV/SEO-Helper/pull/26#issuecomment-282802121, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdTXHVl9xhMJe9FFEW232e0fepPOsKIks5rgxIggaJpZM4MMslu.