search

ARCCSS-extremes / climpact

Calculate the ET-SCI climate extremes indices
GNU General Public License v3.0
43 stars 30 forks source link

203-bugs-to-fix-refereshing-station-file-should-update-images #50

Closed jmccomb closed 3 years ago

jmccomb commented 3 years ago

No longer suspending slickRQC element when hidden/ Updating reactiveVal holding list of image file paths to display. Goes to none when QC validation fails. Removed bottom panel (navigator) as it would not be removed when updating file list due to js error.

heroldn commented 3 years ago

Thanks Jonathan, I tested and the images seem to refresh now, great. But I notice now the QC images (step 2) have a slightly different layout and are now different to how images are shown in step 3. Biggest difference is that there's no preview slider at the bottom like there is in step 3 and the images are crammed together too closely I'd say. Not sure if this is just a new bug but I like how it is in step 3.

jmccomb commented 3 years ago

Yes, that’s correct. That’s a result of the fix.

I prefer the step 3 layout as well, but updating both the main image and footer is broken and I couldn’t find a way to resolve it. The footer would not be removed. Each time you upload a new file you will see an extra footer… So, uploading ten files and clicking the QC button would give you ten footers!

Cheers, Jonathan

From: heroldn notifications@github.com Sent: Monday, 9 November 2020 9:31 AM To: ARCCSS-extremes/climpact climpact@noreply.github.com Cc: Jonathan McComb jmccomb@infoasis.com.au; Author author@noreply.github.com Subject: Re: [ARCCSS-extremes/climpact] 203-bugs-to-fix-refereshing-station-file-should-update-images (#50)

Thanks Jonathan, I tested and the images seem to refresh now, great. But I notice now the QC images (step 2) have a slightly different layout and are now different to how images are shown in step 3. Biggest difference is that there's no preview slider at the bottom like there is in step 3 and the images are crammed together too closely I'd say. Not sure if this is just a new bug but I like how it is in step 3.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ARCCSS-extremes/climpact/pull/50#issuecomment-723675490, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWIEFEUIIS2PYS7KUOHQJDSO4L3DANCNFSM4TMJC7DA.