search

ARCCSS-extremes / climpact

Calculate the ET-SCI climate extremes indices
GNU General Public License v3.0
43 stars 30 forks source link

Install filed and symbol bugs #63

Closed silverbullet1472 closed 3 years ago

silverbullet1472 commented 3 years ago

thanks for the work! but I noticed some bug: 1.the install command in userguide is wrong('source('installers/climpact.master.installer.r').' But there is no installers) 2.the copyright symbol in ui/ui.r will cause some invalid symbol problem(I am opening with UTF-8, maybe because my laptop system setting is China?) 3.cannot runApp successfully

runApp()

Listening on http://127.0.0.1:4049 Warning: Error in library: there is no package called ‘climdex.pcic.ncdf’ 56: Error in library(climdex.pcic.ncdf) : there is no package called ‘climdex.pcic.ncdf’

silverbullet1472 commented 3 years ago

Hello！ Thanks for your work on new version again! As mentioned above there is some bug, but I could still use it to batch process. A little question: Is heat wave excluded when calculating trends? I noticed that in indices folder there are heatwave-related files but no record in trends file.

heroldn commented 3 years ago

Hi

I've updated the user guide and removed that symbol.

Thanks for the feedback.

Nick.

On 30/12/2020 01:11 Jiaqi Ding <notifications@github.com> wrote:

thanks for the work!
but I noticed some bug:
**1.**the install command in userguide is wrong('source('installers/climpact.master.installer.r').' But there is no installers)
**2.**the copyright symbol in ui/ui.r will cause some invalid symbol problem(I am opening with UTF-8, maybe because my laptop system setting is China?)
**3.**cannot runApp successfully

    > > 
    runApp()

>

Listening on http://127.0.0.1:4049 Warning: Error in library: there is no package called ‘climdex.pcic.ncdf’ 56: Error in library(climdex.pcic.ncdf) : there is no package called ‘climdex.pcic.ncdf’

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/ARCCSS-extremes/climpact/issues/63 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW3FAI264PDUJOKQ6HV673SXHPQBANCNFSM4VNH6PQA .
heroldn commented 3 years ago

Thanks for this too. I've added it to the TO-DO list.

On 03/01/2021 23:44 Jiaqi Ding <notifications@github.com> wrote:

Hello！
Thanks for your work on new version again! As mentioned above there is some bug, but I could still use it to batch process.
A little question: Is heat wave excluded when calculating trends? I noticed that in indices folder there are heatwave-related files but no record in trends file.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/ARCCSS-extremes/climpact/issues/63#issuecomment-753611673 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW3FANEDK4VEEOPGNFS6VTSYBRDVANCNFSM4VNH6PQA .
heroldn commented 3 years ago

RE your runApp() error, did you manage to run the climpact.master.installer.r script successfully?

silverbullet1472 commented 3 years ago

RE your runApp() error, did you manage to run the climpact.master.installer.r script successfully? Hello! Yes, alought the path was wrong, I found the installer script and run it. Maybe there was some error during the installation, but since I only used batch script so I did not work on that afterwards.

silverbullet1472 commented 3 years ago

RunAppError InstallError

Hi, I redownload the code from github yesterday(2021/2/3), and this is the error information when I use installer script and runapp() function. Hope it;s helpful.

heroldn commented 3 years ago

I've adjusted the installer script so it should only install the netcdf package that was causing the original error here if it detects it is on a *nix system. I've also removed the erroneous reference to Runit which isn't needed.